[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-4.1 03/24] replay: disable default snapshot for
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [PATCH for-4.1 03/24] replay: disable default snapshot for record/replay |
Date: |
Fri, 21 Jun 2019 11:20:55 +0300 |
User-agent: |
StGit/0.17.1-dirty |
From: Pavel Dovgalyuk <address@hidden>
This patch disables setting '-snapshot' option on by default
in record/replay mode. This is needed for creating vmstates in record
and replay modes.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
Acked-by: Kevin Wolf <address@hidden>
---
vl.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 99a56b5556..8fcfd905ee 100644
--- a/vl.c
+++ b/vl.c
@@ -1208,7 +1208,7 @@ static void configure_blockdev(BlockdevOptionsQueue
*bdo_queue,
qapi_free_BlockdevOptions(bdo->bdo);
g_free(bdo);
}
- if (snapshot || replay_mode != REPLAY_MODE_NONE) {
+ if (snapshot) {
qemu_opts_foreach(qemu_find_opts("drive"), drive_enable_snapshot,
NULL, NULL);
}
@@ -3128,7 +3128,13 @@ int main(int argc, char **argv, char **envp)
drive_add(IF_PFLASH, -1, optarg, PFLASH_OPTS);
break;
case QEMU_OPTION_snapshot:
- snapshot = 1;
+ {
+ Error *blocker = NULL;
+ snapshot = 1;
+ error_setg(&blocker, QERR_REPLAY_NOT_SUPPORTED,
+ "-snapshot");
+ replay_add_blocker(blocker);
+ }
break;
case QEMU_OPTION_numa:
opts = qemu_opts_parse_noisily(qemu_find_opts("numa"),
- [Qemu-devel] [PATCH for-4.1 21/24] util/qemu-timer: refactor deadline calculation for external timers, (continued)
- [Qemu-devel] [PATCH for-4.1 21/24] util/qemu-timer: refactor deadline calculation for external timers, Pavel Dovgalyuk, 2019/06/21
- [Qemu-devel] [PATCH for-4.1 18/24] replay: describe reverse debugging in docs/replay.txt, Pavel Dovgalyuk, 2019/06/21
- [Qemu-devel] [PATCH for-4.1 17/24] gdbstub: add reverse continue support in replay mode, Pavel Dovgalyuk, 2019/06/21
- [Qemu-devel] [PATCH for-4.1 20/24] replay: document development rules, Pavel Dovgalyuk, 2019/06/21
- [Qemu-devel] [PATCH for-4.1 14/24] replay: refine replay-time module, Pavel Dovgalyuk, 2019/06/21
- [Qemu-devel] [PATCH for-4.1 09/24] replay: provide an accessor for rr filename, Pavel Dovgalyuk, 2019/06/21
- [Qemu-devel] [PATCH for-4.1 08/24] migration: introduce icount field for snapshots, Pavel Dovgalyuk, 2019/06/21
- [Qemu-devel] [PATCH for-4.1 16/24] gdbstub: add reverse step support in replay mode, Pavel Dovgalyuk, 2019/06/21
- [Qemu-devel] [PATCH for-4.1 10/24] qapi: introduce replay.json for record/replay-related stuff, Pavel Dovgalyuk, 2019/06/21
- [Qemu-devel] [PATCH for-4.1 06/24] replay: finish record/replay before closing the disks, Pavel Dovgalyuk, 2019/06/21
- [Qemu-devel] [PATCH for-4.1 03/24] replay: disable default snapshot for record/replay,
Pavel Dovgalyuk <=
- [Qemu-devel] [PATCH for-4.1 24/24] icount: clean up cpu_can_io before jumping to the next block, Pavel Dovgalyuk, 2019/06/21
- [Qemu-devel] [PATCH for-4.1 12/24] replay: introduce breakpoint at the specified step, Pavel Dovgalyuk, 2019/06/21
- [Qemu-devel] [PATCH for-4.1 07/24] qcow2: introduce icount field for snapshots, Pavel Dovgalyuk, 2019/06/21
- [Qemu-devel] [PATCH for-4.1 05/24] replay: don't drain/flush bdrv queue while RR is working, Pavel Dovgalyuk, 2019/06/21
- [Qemu-devel] [PATCH for-4.1 02/24] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2019/06/21
- [Qemu-devel] [PATCH for-4.1 04/24] replay: update docs for record/replay with block devices, Pavel Dovgalyuk, 2019/06/21
- [Qemu-devel] [PATCH for-4.1 01/24] replay: add missing fix for internal function, Pavel Dovgalyuk, 2019/06/21
- Re: [Qemu-devel] [PATCH for-4.1 00/24] Fix record/replay and add reverse debugging, no-reply, 2019/06/21
- Re: [Qemu-devel] [PATCH for-4.1 00/24] Fix record/replay and add reverse debugging, dovgaluk, 2019/06/27