[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer
From: |
Wei Yang |
Subject: |
Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer |
Date: |
Fri, 21 Jun 2019 15:43:00 +0800 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Tue, Jun 11, 2019 at 10:33:29AM +0200, Juan Quintela wrote:
>Wei Yang <address@hidden> wrote:
>> On Tue, Apr 02, 2019 at 08:31:06AM +0800, Wei Yang wrote:
>>>MigrationState->bytes_xfer is only set to 0 in migrate_init().
>>>
>>>Remove this unnecessary field.
>>>
>>>Signed-off-by: Wei Yang <address@hidden>
>>
>> Hi, David
>
>Hi
>
>I am on duty this week, will get it.
>
Hi, Juan,
May I ask when you are willing to pick it up?
>>
>> Are you willing to pick up this one?
>>
>>>---
>>> migration/migration.c | 1 -
>>> migration/migration.h | 1 -
>>> 2 files changed, 2 deletions(-)
>>>
>>>diff --git a/migration/migration.c b/migration/migration.c
>>>index dea7078bf4..c929cf8d0f 100644
>>>--- a/migration/migration.c
>>>+++ b/migration/migration.c
>>>@@ -1681,7 +1681,6 @@ void migrate_init(MigrationState *s)
>>> * parameters/capabilities that the user set, and
>>> * locks.
>>> */
>>>- s->bytes_xfer = 0;
>>> s->cleanup_bh = 0;
>>> s->to_dst_file = NULL;
>>> s->rp_state.from_dst_file = NULL;
>>>diff --git a/migration/migration.h b/migration/migration.h
>>>index 852eb3c4e9..b9efbe9168 100644
>>>--- a/migration/migration.h
>>>+++ b/migration/migration.h
>>>@@ -116,7 +116,6 @@ struct MigrationState
>>> DeviceState parent_obj;
>>>
>>> /*< public >*/
>>>- size_t bytes_xfer;
>>> QemuThread thread;
>>> QEMUBH *cleanup_bh;
>>> QEMUFile *to_dst_file;
>>>--
>>>2.19.1
--
Wei Yang
Help you, Help me