Re: [Qemu-devel] [PATCH 10/17] hw/core: Collect QMP command handlers in hw/core/

[Daniel P . Berrangé]

On Wed, Jun 19, 2019 at 10:10:43PM +0200, Markus Armbruster wrote:
> The handlers for qapi/machine.json's QMP commands are spread over
> cpus.c, hw/core/numa.c, monitor/misc.c, monitor/qmp-cmds.c, and vl.c.
> Move them all to new hw/core/machine-qmp-cmds.c, where they are
> covered by MAINTAINERS section "Machine core", just like
> qapi/machine.json.
> 
> Cc: Eduardo Habkost <address@hidden>
> Cc: Marcel Apfelbaum <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  MAINTAINERS                |   1 +
>  cpus.c                     | 188 ---------------------
>  hw/core/Makefile.objs      |   1 +
>  hw/core/machine-qmp-cmds.c | 328 +++++++++++++++++++++++++++++++++++++
>  hw/core/numa.c             |  62 -------
>  include/sysemu/numa.h      |   2 +
>  monitor/misc.c             |  13 --
>  monitor/qmp-cmds.c         |  12 --
>  vl.c                       |  45 -----
>  9 files changed, 332 insertions(+), 320 deletions(-)
>  create mode 100644 hw/core/machine-qmp-cmds.c

Reviewed-by: Daniel P. Berrangé <address@hidden>



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|