[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6] vfio-ccw: support async command subregion
From: |
Eric Farman |
Subject: |
Re: [Qemu-devel] [PATCH v6] vfio-ccw: support async command subregion |
Date: |
Wed, 19 Jun 2019 15:05:25 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/13/19 5:25 AM, Cornelia Huck wrote:
> A vfio-ccw device may provide an async command subregion for
> issuing halt/clear subchannel requests. If it is present, use
> it for sending halt/clear request to the device; if not, fall
> back to emulation (as done today).
>
> Reviewed-by: Farhan Ali <address@hidden>
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
>
> v5->v6:
> - plug a memory leak [Farhan]
>
> v4->v5:
> - It seems we need to take the indirection via the class for the
> callbacks after all :(
> - Dropped Eric's R-b: for that reason
I've finally looked over this version, and think it looks good. Feel
free to add this back:
Reviewed-by: Eric Farman <address@hidden>