Re: [Qemu-devel] [RFC] spice-core: allow setting properties from QMP

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [RFC] spice-core: allow setting properties from QMP
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
51809fd99d spice-core: allow setting properties from QMP

=== OUTPUT BEGIN ===
ERROR: open brace '{' following function declarations go on the next line
#61: FILE: ui/spice-core.c:506:
+void qmp_set_spice(const char *property, const char *value, Error **errp) {

ERROR: Error messages should not contain newlines
#67: FILE: ui/spice-core.c:512:
+                       "the property %s=%s\n", invalid_codecs, property, 
value);

WARNING: line over 80 characters
#70: FILE: ui/spice-core.c:515:
+        error_setg(errp, "Setting an unknown spice property (%s=%s)\n", 
property, value);

ERROR: Error messages should not contain newlines
#70: FILE: ui/spice-core.c:515:
+        error_setg(errp, "Setting an unknown spice property (%s=%s)\n", 
property, value);

ERROR: Missing Signed-off-by: line(s)

total: 4 errors, 1 warnings, 44 lines checked

Commit 51809fd99d76 (spice-core: allow setting properties from QMP) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden