Re: [Qemu-devel] [RFC PATCH v2 20/35] multi-process: Add QMP & extend HMP commands to list remote info

[Eric Blake]

On 6/17/19 1:16 PM, address@hidden wrote:
> From: Jagannathan Raman <address@hidden>
> 
> Add query-remote QMP command and extend "info" HMP command, to list
> the remote objects used by QEMU.
> 
> Signed-off-by: Jagannathan Raman <address@hidden>
> Signed-off-by: John G Johnson <address@hidden>
> Signed-off-by: Elena Ufimtseva <address@hidden>
> ---

> +++ b/qapi/block-core.json
> @@ -673,6 +673,23 @@
>             '*tray_open': 'bool', '*io-status': 'BlockDeviceIoStatus',
>             '*dirty-bitmaps': ['BlockDirtyInfo'] } }
>  
> +##
> +# @RemoteProc:

Unless there's a compelling reason to abbreviate, naming this
'RemoteProcess' is just fine.

> +#
> +# Remote process information.
> +#
> +# @id: Device ID
> +#
> +# @pid: Linux Process ID

Is this information only available for Linux, or is it a generic pid
appropriate to any operating system?  I'm wondering if you can just
s/Linux//.

> +#
> +# @proc: Process name

Again, no need to abbreviate, if @process or @name would be easier to
document.

> +#
> +# Since:  3.0.93

No such release. The next release will be 4.1.

> +##
> +{ 'struct': 'RemoteProc',
> +  'data': {'id': 'str', 'pid': 'int32', 'proc': 'str' },
> +  'if': 'defined(CONFIG_MPQEMU)' }
> +
>  ##
>  # @BlockMeasureInfo:
>  #
> @@ -795,6 +812,18 @@
>  ##
>  { 'command': 'query-block', 'returns': ['BlockInfo'] }
>  
> +##
> +# @query-remote:
> +#
> +# Get a list of all the remote processes spawned by QEMU.
> +#
> +# Returns: a list of @RemoteProc describing each remote process.
> +#
> +# Since: 3.0.93

4.1

> +#
> +##
> +{ 'command': 'query-remote', 'returns': ['RemoteProc'],
> +  'if': 'defined(CONFIG_MPQEMU)' }
>  
>  ##
>  # @BlockDeviceTimedStats:
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature