[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [SeaBIOS] [QEMU] [PATCH v3 0/8] Add Qemu to SeaBIOS LCH
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [SeaBIOS] [QEMU] [PATCH v3 0/8] Add Qemu to SeaBIOS LCHS interface |
Date: |
Mon, 17 Jun 2019 09:45:23 -0700 (PDT) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Type: series
Subject: [SeaBIOS] [QEMU] [PATCH v3 0/8] Add Qemu to SeaBIOS LCHS interface
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
5d0e569..076243f master -> master
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
fd108cd hd-geo-test: Add tests for lchs override
48924b4 bootdevice: FW_CFG interface for LCHS values
a5d9c05 bootdevice: Refactor get_boot_devices_list
4bbd8b3 bootdevice: Gather LCHS from all relevant devices
0c1a116 scsi: Propagate unrealize() callback to scsi-hd
e67cc65 bootdevice: Add interface to gather LCHS
4ee45e1 block: Support providing LCHS from user
20c9570 block: Refactor macros - fix tabbing
=== OUTPUT BEGIN ===
1/8 Checking commit 20c9570c533d (block: Refactor macros - fix tabbing)
ERROR: Macros with complex values should be enclosed in parenthesis
#55: FILE: include/hw/block/block.h:65:
+#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \
+ DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0), \
+ DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0), \
DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0)
total: 1 errors, 0 warnings, 37 lines checked
Patch 1/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/8 Checking commit 4ee45e1aba23 (block: Support providing LCHS from user)
3/8 Checking commit e67cc65e5e42 (bootdevice: Add interface to gather LCHS)
4/8 Checking commit 0c1a116c12b8 (scsi: Propagate unrealize() callback to
scsi-hd)
5/8 Checking commit 4bbd8b3f99c7 (bootdevice: Gather LCHS from all relevant
devices)
6/8 Checking commit a5d9c05dfa78 (bootdevice: Refactor get_boot_devices_list)
7/8 Checking commit 48924b42fc79 (bootdevice: FW_CFG interface for LCHS values)
8/8 Checking commit fd108cda4981 (hd-geo-test: Add tests for lchs override)
WARNING: Block comments use a leading /* on a separate line
#625: FILE: tests/hd-geo-test.c:980:
+ "skipping hd-geo/override/* tests");
total: 0 errors, 1 warnings, 593 lines checked
Patch 8/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [QEMU] [PATCH v3 0/8] Add Qemu to SeaBIOS LCHS interface, Sam Eiderman, 2019/06/17
- [Qemu-devel] [QEMU] [PATCH v3 2/8] block: Support providing LCHS from user, Sam Eiderman, 2019/06/17
- [Qemu-devel] [QEMU] [PATCH v3 3/8] bootdevice: Add interface to gather LCHS, Sam Eiderman, 2019/06/17
- [Qemu-devel] [QEMU] [PATCH v3 4/8] scsi: Propagate unrealize() callback to scsi-hd, Sam Eiderman, 2019/06/17
- [Qemu-devel] [QEMU] [PATCH v3 5/8] bootdevice: Gather LCHS from all relevant devices, Sam Eiderman, 2019/06/17
- [Qemu-devel] [QEMU] [PATCH v3 6/8] bootdevice: Refactor get_boot_devices_list, Sam Eiderman, 2019/06/17
- [Qemu-devel] [QEMU] [PATCH v3 7/8] bootdevice: FW_CFG interface for LCHS values, Sam Eiderman, 2019/06/17
- [Qemu-devel] [QEMU] [PATCH v3 8/8] hd-geo-test: Add tests for lchs override, Sam Eiderman, 2019/06/17
- [Qemu-devel] [QEMU] [PATCH v3 1/8] block: Refactor macros - fix tabbing, Sam Eiderman, 2019/06/17
- Re: [Qemu-devel] [SeaBIOS] [QEMU] [PATCH v3 0/8] Add Qemu to SeaBIOS LCHS interface, no-reply, 2019/06/17
- Re: [Qemu-devel] [SeaBIOS] [QEMU] [PATCH v3 0/8] Add Qemu to SeaBIOS LCHS interface,
no-reply <=