[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 02/15] target/ppc: remove getVSR()/putVSR() f
|
From: |
Mark Cave-Ayland |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 02/15] target/ppc: remove getVSR()/putVSR() from mem_helper.c |
|
Date: |
Sun, 16 Jun 2019 08:57:44 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 |
On 12/06/2019 20:47, Richard Henderson wrote:
> On 6/2/19 4:08 AM, Mark Cave-Ayland wrote:
>> - getVSR(xt_num, &xt, env); \
>> + \
>> nb = (nb >= 16) ? 16 : nb; \
>> if (msr_le && !lj) { \
>> for (i = 16; i > 16 - nb; i--) { \
>> - cpu_stb_data_ra(env, addr, xt.VsrB(i - 1), GETPC()); \
>> + cpu_stb_data_ra(env, addr, t.VsrB(i - 1), GETPC()); \
>> addr = addr_add(env, addr, 1); \
>> } \
>> } else { \
>> for (i = 0; i < nb; i++) { \
>> - cpu_stb_data_ra(env, addr, xt.VsrB(i), GETPC()); \
>> + cpu_stb_data_ra(env, addr, t.VsrB(i), GETPC()) ; \
>> addr = addr_add(env, addr, 1); \
>> } \
>> } \
>> + *xt = t; \
>
> Do not write back stores.
Yeah, my mistake - David also managed to spot this one.
> Actually, in this case there's no reason to copy t = *xt. Just store directly
> from xt->VsrB(i).
Okay I'll fix that in v3.
ATB,
Mark.
[Qemu-devel] [PATCH v2 02/15] target/ppc: remove getVSR()/putVSR() from mem_helper.c, Mark Cave-Ayland, 2019/06/02
[Qemu-devel] [PATCH v2 03/15] target/ppc: remove getVSR()/putVSR() from int_helper.c, Mark Cave-Ayland, 2019/06/02
[Qemu-devel] [PATCH v2 05/15] target/ppc: introduce GEN_VSX_HELPER_X3 macro to fpu_helper.c, Mark Cave-Ayland, 2019/06/02
[Qemu-devel] [PATCH v2 09/15] target/ppc: introduce GEN_VSX_HELPER_X1 macro to fpu_helper.c, Mark Cave-Ayland, 2019/06/02
[Qemu-devel] [PATCH v2 08/15] target/ppc: introduce GEN_VSX_HELPER_X2_AB macro to fpu_helper.c, Mark Cave-Ayland, 2019/06/02
[Qemu-devel] [PATCH v2 07/15] target/ppc: introduce GEN_VSX_HELPER_X2 macro to fpu_helper.c, Mark Cave-Ayland, 2019/06/02