Re: [Qemu-devel] [PATCH v3 07/15] Move monitor.c to monitor/misc.c

[Markus Armbruster]

Markus Armbruster <address@hidden> writes:

> Kevin Wolf <address@hidden> writes:
>
>> Create a new monitor/ subdirectory and move monitor.c there. As the plan
>> is to move the monitor core into separate files, use the chance to
>> rename it to misc.c.
>>
>> Signed-off-by: Kevin Wolf <address@hidden>
>> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>> Reviewed-by: Markus Armbruster <address@hidden>
>> ---
>>  docs/devel/writing-qmp-commands.txt |  2 +-
>>  monitor.c => monitor/misc.c         |  2 +-
>>  MAINTAINERS                         |  4 ++--
>>  Makefile.objs                       |  1 +
>>  Makefile.target                     |  3 ++-
>>  monitor/Makefile.objs               |  1 +
>>  monitor/trace-events                | 11 +++++++++++
>>  trace-events                        | 10 ----------
>>  8 files changed, 19 insertions(+), 15 deletions(-)
>>  rename monitor.c => monitor/misc.c (99%)
>>  create mode 100644 monitor/Makefile.objs
>>  create mode 100644 monitor/trace-events
>
> I still think we should move hmp.h to include/monitor/.

Comment applies to the next patch, sorry.

> hmp-commands-info.hx and hmp-commands.hx, too.  Not worth a respin by
> itself.