[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 01/20] hw/i386/pc: Use unsigned type to index arr
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-devel] [PATCH v2 01/20] hw/i386/pc: Use unsigned type to index arrays |
Date: |
Thu, 13 Jun 2019 16:34:27 +0200 |
Reviewed-by: Li Qiang <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/i386/pc.c | 5 +++--
include/hw/i386/pc.h | 2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 2c5446b095..bb3c74f4ca 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -874,7 +874,7 @@ static void handle_a20_line_change(void *opaque, int irq,
int level)
int e820_add_entry(uint64_t address, uint64_t length, uint32_t type)
{
- int index = le32_to_cpu(e820_reserve.count);
+ unsigned int index = le32_to_cpu(e820_reserve.count);
struct e820_entry *entry;
if (type != E820_RAM) {
@@ -906,7 +906,8 @@ int e820_get_num_entries(void)
return e820_entries;
}
-bool e820_get_entry(int idx, uint32_t type, uint64_t *address, uint64_t
*length)
+bool e820_get_entry(unsigned int idx, uint32_t type,
+ uint64_t *address, uint64_t *length)
{
if (idx < e820_entries && e820_table[idx].type == cpu_to_le32(type)) {
*address = le64_to_cpu(e820_table[idx].address);
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index a7d0b87166..3b3a0d6e59 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -291,7 +291,7 @@ void pc_madt_cpu_entry(AcpiDeviceIf *adev, int uid,
int e820_add_entry(uint64_t, uint64_t, uint32_t);
int e820_get_num_entries(void);
-bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
+bool e820_get_entry(unsigned int, uint32_t, uint64_t *, uint64_t *);
extern GlobalProperty pc_compat_4_0_1[];
extern const size_t pc_compat_4_0_1_len;
--
2.20.1
- [Qemu-devel] [PATCH v2 00/20] hw/i386/pc: Do not restrict the fw_cfg functions to the PC machine, Philippe Mathieu-Daudé, 2019/06/13
- [Qemu-devel] [PATCH v2 05/20] hw/i386/pc: Add documentation to the e820_*() functions, Philippe Mathieu-Daudé, 2019/06/13
- [Qemu-devel] [PATCH v2 06/20] hw/i386/pc: Use e820_get_num_entries() to access e820_entries, Philippe Mathieu-Daudé, 2019/06/13
- [Qemu-devel] [PATCH v2 01/20] hw/i386/pc: Use unsigned type to index arrays,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v2 04/20] hw/i386/pc: Add the E820Type enum type, Philippe Mathieu-Daudé, 2019/06/13
- [Qemu-devel] [PATCH v2 08/20] hw/i386/pc: Use address_space_memory in place, Philippe Mathieu-Daudé, 2019/06/13
- [Qemu-devel] [PATCH v2 02/20] hw/i386/pc: Use size_t type to hold/return a size of array, Philippe Mathieu-Daudé, 2019/06/13
- [Qemu-devel] [PATCH v2 03/20] hw/i386/pc: Let e820_add_entry() return a ssize_t type, Philippe Mathieu-Daudé, 2019/06/13