Re: [Qemu-devel] [PATCH v2 04/15] target/ppc: introduce separate VSX_CMP macro for xvcmp* instructions

[Richard Henderson]

On 6/2/19 4:08 AM, Mark Cave-Ayland wrote:
> Rather than perform the VSR register decoding within the helper itself,
> introduce a new VSX_CMP macro which performs the decode based upon xT, xA
> and xB at translation time.
> 
> Subsequent commits will make the same changes for other instructions however
> the xvcmp* instructions are different in that they return a set of flags to be
> optionally written back to the crf[6] register. Move this logic from the
> helper function to the generator function, along with the float_status update.
> 
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> ---
>  target/ppc/fpu_helper.c             | 15 +++++-------
>  target/ppc/helper.h                 | 20 +++++++++------
>  target/ppc/translate/vsx-impl.inc.c | 49 
> +++++++++++++++++++++++++++++++------
>  3 files changed, 59 insertions(+), 25 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~