qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v12 4/7] dm: enable synchronous dax


From: Pankaj Gupta
Subject: Re: [Qemu-devel] [PATCH v12 4/7] dm: enable synchronous dax
Date: Tue, 11 Jun 2019 22:23:09 -0400 (EDT)

> On Tue, Jun 11 2019 at 12:37pm -0400,
> Pankaj Gupta <address@hidden> wrote:
> 
> > This patch sets dax device 'DAXDEV_SYNC' flag if all the target
> > devices of device mapper support synchrononous DAX. If device
> > mapper consists of both synchronous and asynchronous dax devices,
> > we don't set 'DAXDEV_SYNC' flag.
> > 
> > 'dm_table_supports_dax' is refactored to pass 'iterate_devices_fn'
> > as argument so that the callers can pass the appropriate functions.
> > 
> > Suggested-by: Mike Snitzer <address@hidden>
> > Signed-off-by: Pankaj Gupta <address@hidden>
> 
> Thanks, and for the benefit of others, passing function pointers like
> this is perfectly fine IMHO because this code is _not_ in the fast
> path.  These methods are only for device creation.
> 
> Reviewed-by: Mike Snitzer <address@hidden>

Thank you, Mike

Best regards,
Pankaj

> 
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]