Re: [Qemu-devel] [PULL 00/12] Miscellaneous patches for 2019-06-07

[Markus Armbruster]

Peter Maydell <address@hidden> writes:

> On Fri, 7 Jun 2019 at 19:21, Markus Armbruster <address@hidden> wrote:
>>
>> The following changes since commit 0d74f3b4277a7ecb0ccb80c865797d11f8e466f5:
>>
>>   Merge remote-tracking branch 
>> 'remotes/vivier2/tags/trivial-branch-pull-request' into staging (2019-06-06 
>> 14:09:14 +0100)
>>
>> are available in the Git repository at:
>>
>>   git://repo.or.cz/qemu/armbru.git tags/pull-misc-2019-06-07
>>
>> for you to fetch changes up to 516741ebae8e2baef456c10897569725663157dd:
>>
>>   MAINTAINERS: Polish headline decorations (2019-06-07 16:30:59 +0200)
>>
>> ----------------------------------------------------------------
>> Miscellaneous patches for 2019-06-07
>>
>> ----------------------------------------------------------------
>> Markus Armbruster (11):
>>       qemu-common: Move tcg_enabled() etc. to sysemu/tcg.h
>>       qemu-common: Move qemu_isalnum() etc. to qemu/ctype.h
>>       Include qemu/module.h where needed, drop it from qemu-common.h
>>       Include qemu-common.h exactly where needed
>>       Normalize position of header guard
>>       scripts/clean-header-guards: Fix handling of trailing comments
>>       Clean up a few header guard symbols
>>       Supply missing header guards
>>       Clean up a header guard symbols (again)
>>       MAINTAINERS: Improve section headlines
>>       MAINTAINERS: Polish headline decorations
>>
>> Philippe Mathieu-Daudé (1):
>>       MAINTAINERS: Remove duplicate entries of address@hidden
>>
>
> Compile failure, I'm afraid, on OSX, NetBSD, FreeBSD and OpenBSD:
>
> /Users/pm215/src/qemu-for-merges/net/tap-bsd.c:68:9: error: implicit
> declaration of function 'TFR' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
>         TFR(fd = open(dname, O_RDWR));
>         ^
> /Users/pm215/src/qemu-for-merges/net/tap-bsd.c:68:9: error: this
> function declaration is not a prototype [-Werror,-Wstrict-prototypes]

Fortunately, this was the only one (I rustled up a cfarm machine to
check).  Unfortunately, I had to rebase to make it again mergable into
master.  Fresh pull request sent.  Thanks!