Re: [Qemu-devel] [PULL 00/39] tcg: Move the softmmu tlb to CPUNegativeOffsetState

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/39] tcg: Move the softmmu tlb to 
CPUNegativeOffsetState

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
14c3ef7 tcg/arm: Remove mostly unreachable tlb special case
4b69ec8 tcg/arm: Use LDRD to load tlb mask+table
c9f7425 tcg/aarch64: Use LDP to load tlb mask+table
a893d89 cpu: Remove CPU_COMMON
8f9c8d6 cpu: Move the softmmu tlb to CPUNegativeOffsetState
2551086 cpu: Move icount_decr to CPUNegativeOffsetState
0a1137b cpu: Introduce CPUNegativeOffsetState
b64e470 cpu: Introduce cpu_set_cpustate_pointers
2a23caa cpu: Move ENV_OFFSET to exec/gen-icount.h
e08735f target/xtensa: Use env_cpu, env_archcpu
645c46c target/unicore32: Use env_cpu, env_archcpu
6709e7d target/tricore: Use env_cpu
976835d target/tilegx: Use env_cpu
a711dbf target/sparc: Use env_cpu, env_archcpu
569f3d9 target/sh4: Use env_cpu, env_archcpu
3c61f09 target/s390x: Use env_cpu, env_archcpu
9313c73 target/riscv: Use env_cpu, env_archcpu
173e48f target/ppc: Use env_cpu, env_archcpu
f84d7f8 target/openrisc: Use env_cpu, env_archcpu
393a70d target/nios2: Use env_cpu, env_archcpu
c695005 target/moxie: Use env_cpu, env_archcpu
a4e8def target/mips: Use env_cpu, env_archcpu
a6515fe target/microblaze: Use env_cpu, env_archcpu
63a9a1c target/m68k: Use env_cpu
3b316f1 target/lm32: Use env_cpu, env_archcpu
82efaa6 target/i386: Use env_cpu, env_archcpu
11c992f target/hppa: Use env_cpu, env_archcpu
de08093 target/cris: Use env_cpu, env_archcpu
a525f0d target/cris: Reindent op_helper.c
065f3b4 target/cris: Reindent mmu.c
6302f94 target/arm: Use env_cpu, env_archcpu
1f3027f target/alpha: Use env_cpu, env_archcpu
00a7c19 cpu: Introduce env_archcpu
b18aedf cpu: Replace ENV_GET_CPU with env_cpu
cecbcff cpu: Define ArchCPU
04707fb cpu: Define CPUArchState with typedef
16c2a7d tcg: Create struct CPUTLB
8534521 tcg: Split out target/arch/cpu-param.h
449faed tcg: Fold CPUTLBWindow into CPUTLBDesc

=== OUTPUT BEGIN ===
1/39 Checking commit 449faedd6a35 (tcg: Fold CPUTLBWindow into CPUTLBDesc)
2/39 Checking commit 8534521f7a9b (tcg: Split out target/arch/cpu-param.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#57: 
new file mode 100644

total: 0 errors, 1 warnings, 1290 lines checked

Patch 2/39 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/39 Checking commit 16c2a7daf1f6 (tcg: Create struct CPUTLB)
4/39 Checking commit 04707fb05fed (cpu: Define CPUArchState with typedef)
5/39 Checking commit cecbcff952a4 (cpu: Define ArchCPU)
6/39 Checking commit b18aedfb528a (cpu: Replace ENV_GET_CPU with env_cpu)
7/39 Checking commit 00a7c19a4453 (cpu: Introduce env_archcpu)
8/39 Checking commit 1f3027f13062 (target/alpha: Use env_cpu, env_archcpu)
9/39 Checking commit 6302f943c509 (target/arm: Use env_cpu, env_archcpu)
10/39 Checking commit 065f3b4f397f (target/cris: Reindent mmu.c)
11/39 Checking commit a525f0d79de4 (target/cris: Reindent op_helper.c)
12/39 Checking commit de080934494e (target/cris: Use env_cpu, env_archcpu)
13/39 Checking commit 11c992f99fae (target/hppa: Use env_cpu, env_archcpu)
14/39 Checking commit 82efaa6ec56b (target/i386: Use env_cpu, env_archcpu)
15/39 Checking commit 3b316f1f2b9d (target/lm32: Use env_cpu, env_archcpu)
16/39 Checking commit 63a9a1c41275 (target/m68k: Use env_cpu)
17/39 Checking commit a6515fe51220 (target/microblaze: Use env_cpu, env_archcpu)
18/39 Checking commit a4e8def8ff09 (target/mips: Use env_cpu, env_archcpu)
19/39 Checking commit c69500532ed4 (target/moxie: Use env_cpu, env_archcpu)
20/39 Checking commit 393a70d2de3d (target/nios2: Use env_cpu, env_archcpu)
21/39 Checking commit f84d7f877212 (target/openrisc: Use env_cpu, env_archcpu)
22/39 Checking commit 173e48fee38b (target/ppc: Use env_cpu, env_archcpu)
23/39 Checking commit 9313c73df98a (target/riscv: Use env_cpu, env_archcpu)
24/39 Checking commit 3c61f09fe8e8 (target/s390x: Use env_cpu, env_archcpu)
25/39 Checking commit 569f3d9b29ea (target/sh4: Use env_cpu, env_archcpu)
26/39 Checking commit a711dbf6ec0a (target/sparc: Use env_cpu, env_archcpu)
27/39 Checking commit 976835d19780 (target/tilegx: Use env_cpu)
28/39 Checking commit 6709e7d659a4 (target/tricore: Use env_cpu)
29/39 Checking commit 645c46c65bbf (target/unicore32: Use env_cpu, env_archcpu)
30/39 Checking commit e08735f0d8c4 (target/xtensa: Use env_cpu, env_archcpu)
31/39 Checking commit 2a23caa546af (cpu: Move ENV_OFFSET to exec/gen-icount.h)
32/39 Checking commit b64e470fef4c (cpu: Introduce cpu_set_cpustate_pointers)
33/39 Checking commit 0a1137b8f86b (cpu: Introduce CPUNegativeOffsetState)
34/39 Checking commit 255108651fcc (cpu: Move icount_decr to 
CPUNegativeOffsetState)
ERROR: return is not a function, parentheses are not required
#193: FILE: cpus.c:242:
+    return (cpu->icount_budget -

total: 1 errors, 0 warnings, 326 lines checked

Patch 34/39 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

35/39 Checking commit 8f9c8d67498e (cpu: Move the softmmu tlb to 
CPUNegativeOffsetState)
36/39 Checking commit a893d896a965 (cpu: Remove CPU_COMMON)
37/39 Checking commit c9f74258be93 (tcg/aarch64: Use LDP to load tlb mask+table)
38/39 Checking commit 4b69ec8743d9 (tcg/arm: Use LDRD to load tlb mask+table)
39/39 Checking commit 14c3ef71e449 (tcg/arm: Remove mostly unreachable tlb 
special case)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden