Re: [Qemu-devel] [PATCH v18 00/29] Add RX archtecture support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v18 00/29] Add RX archtecture support
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
5445e98 BootLinuxConsoleTest: Test the RX-Virt machine
6f2b0e9 hw/rx: Fix comments
ead645d hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
7efa4b5 target/rx: Restrict access to extable[]
1a65517 target/rx: Dump bytes for each insn during disassembly
de8c702 target/rx: Collect all bytes during disassembly
4cb3b68 target/rx: Emit all disassembly in one prt()
0ab246d target/rx: Use prt_ldmi for XCHG_mr disassembly
8a49552 target/rx: Replace operand with prt_ldmi in disassembler
c5873c5 target/rx: Disassemble rx_index_addr into a string
1b7300b MAINTAINERS: Add RX
ab21faa Add rx-softmmu
2ee6b02 hw/rx: Honor -accel qtest
24cc3fd tests: Add rx to machine-none-test.c
c61e90f target/rx: Add RX to SysEmuTarget
b91b31c target/rx: Convert to CPUClass::tlb_fill
0dfd9a4 hw/registerfields.h: Add 8bit and 16bit register macros
63b30a3 qemu/bitops.h: Add extract8 and extract16
2e4764c !fixup hw/rx: RX Target hardware definition
917e62d hw/rx: RX Target hardware definition
5c1587e hw/char: RX62N serial communication interface (SCI)
6ac20f4 hw/timer: RX62N internal timer modules
cb2f94c hw/intc: RX62N interrupt controller (ICUa)
f6512cb target/rx: RX disassembler
82b16cc !fixup target/rx: CPU definition
da582b7 !fixup target/rx: CPU definition
3ebcbeb target/rx: CPU definition
3f3ac5e target/rx: TCG helper
b5145b1 target/rx: TCG translation

=== OUTPUT BEGIN ===
1/29 Checking commit b5145b12c648 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 1/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/29 Checking commit 3f3ac5e47497 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 660 lines checked

Patch 2/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/29 Checking commit 3ebcbeb128d3 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 599 lines checked

Patch 3/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/29 Checking commit da582b7342c7 (!fixup target/rx: CPU definition)
5/29 Checking commit 82b16cce53f5 (!fixup target/rx: CPU definition)
6/29 Checking commit f6512cb74875 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 6/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/29 Checking commit cb2f94cc7527 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 7/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/29 Checking commit 6ac20f498fb3 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 839 lines checked

Patch 8/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/29 Checking commit 5c1587e1b36f (hw/char: RX62N serial communication 
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 9/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/29 Checking commit 917e62dcdb9a (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

total: 0 errors, 1 warnings, 460 lines checked

Patch 10/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/29 Checking commit 2e4764c0f04a (!fixup hw/rx: RX Target hardware definition)
12/29 Checking commit 63b30a362289 (qemu/bitops.h: Add extract8 and extract16)
13/29 Checking commit 0dfd9a40f5f1 (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2467.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#26: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#30: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 13/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

14/29 Checking commit b91b31c9b700 (target/rx: Convert to CPUClass::tlb_fill)
15/29 Checking commit c61e90fdd59b (target/rx: Add RX to SysEmuTarget)
16/29 Checking commit 24cc3fda7c07 (tests: Add rx to machine-none-test.c)
17/29 Checking commit 2ee6b02ab486 (hw/rx: Honor -accel qtest)
18/29 Checking commit ab21faaf4a3c (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 52 lines checked

Patch 18/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/29 Checking commit 1b7300bdbeaf (MAINTAINERS: Add RX)
20/29 Checking commit c5873c58bcf0 (target/rx: Disassemble rx_index_addr into a 
string)
21/29 Checking commit 8a495529ced5 (target/rx: Replace operand with prt_ldmi in 
disassembler)
22/29 Checking commit 0ab246d9618d (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
23/29 Checking commit 4cb3b6873725 (target/rx: Emit all disassembly in one 
prt())
24/29 Checking commit de8c702c5aa1 (target/rx: Collect all bytes during 
disassembly)
25/29 Checking commit 1a65517788a5 (target/rx: Dump bytes for each insn during 
disassembly)
26/29 Checking commit 7efa4b5c53db (target/rx: Restrict access to extable[])
27/29 Checking commit ead645d4038c (hw/rx: Restrict the RX62N microcontroller 
to the RX62N CPU core)
28/29 Checking commit 6f2b0e95d5b9 (hw/rx: Fix comments)
29/29 Checking commit 5445e980600a (BootLinuxConsoleTest: Test the RX-Virt 
machine)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden