Re: [Qemu-devel] [PATCH v17 00/24] Add RX archtecture support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v17 00/24] Add RX archtecture support
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
8c36c53a15 target/rx: Remove suffix in cpu class.
7c74fad429 target/rx: Dump bytes for each insn during disassembly
ffd02de520 target/rx: Collect all bytes during disassembly
617040d53b target/rx: Emit all disassembly in one prt()
946b9561b5 target/rx: Use prt_ldmi for XCHG_mr disassembly
a45c45f2b0 target/rx: Replace operand with prt_ldmi in disassembler
41cc509a4f target/rx: Disassemble rx_index_addr into a string
d6082e85f9 MAINTAINERS: Add RX
14cf31b465 Add rx-softmmu
8d2c180952 hw/rx: Honor -accel qtest
db79258006 tests: Add rx to machine-none-test.c
7b3a8dc7d1 target/rx: Fix cpu types and names
3dc8909dc9 target/rx: Add RX to SysEmuTarget
faa146c401 target/rx: Convert to CPUClass::tlb_fill
d6fc0cbb25 hw/registerfields.h: Add 8bit and 16bit register macros
42fe1569a6 qemu/bitops.h: Add extract8 and extract16
76070155e0 hw/rx: RX Target hardware definition
c2487837c0 hw/char: RX62N serial communication interface (SCI)
477bb26880 hw/timer: RX62N internal timer modules
f3d47f3636 hw/intc: RX62N interrupt controller (ICUa)
3be294f121 target/rx: RX disassembler
43573a6282 target/rx: CPU definition
f712756a33 target/rx: TCG helper
e4c37ca6fd target/rx: TCG translation

=== OUTPUT BEGIN ===
1/24 Checking commit e4c37ca6fd60 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 1/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/24 Checking commit f712756a3323 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 660 lines checked

Patch 2/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/24 Checking commit 43573a628243 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 599 lines checked

Patch 3/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/24 Checking commit 3be294f1215b (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 4/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/24 Checking commit f3d47f36367d (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 5/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/24 Checking commit 477bb26880d3 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 839 lines checked

Patch 6/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/24 Checking commit c2487837c01b (hw/char: RX62N serial communication 
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 7/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/24 Checking commit 76070155e0c9 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

total: 0 errors, 1 warnings, 460 lines checked

Patch 8/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/24 Checking commit 42fe1569a60d (qemu/bitops.h: Add extract8 and extract16)
10/24 Checking commit d6fc0cbb25b9 (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value within @rawlines in concatenation (.) or string at 
./scripts/checkpatch.pl line 2467.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#26: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#30: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 10/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/24 Checking commit faa146c40157 (target/rx: Convert to CPUClass::tlb_fill)
12/24 Checking commit 3dc8909dc983 (target/rx: Add RX to SysEmuTarget)
13/24 Checking commit 7b3a8dc7d1f8 (target/rx: Fix cpu types and names)
14/24 Checking commit db7925800679 (tests: Add rx to machine-none-test.c)
15/24 Checking commit 8d2c18095229 (hw/rx: Honor -accel qtest)
16/24 Checking commit 14cf31b465a6 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 45 lines checked

Patch 16/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/24 Checking commit d6082e85f9af (MAINTAINERS: Add RX)
18/24 Checking commit 41cc509a4f64 (target/rx: Disassemble rx_index_addr into a 
string)
19/24 Checking commit a45c45f2b013 (target/rx: Replace operand with prt_ldmi in 
disassembler)
20/24 Checking commit 946b9561b544 (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
21/24 Checking commit 617040d53b58 (target/rx: Emit all disassembly in one 
prt())
22/24 Checking commit ffd02de520a5 (target/rx: Collect all bytes during 
disassembly)
23/24 Checking commit 7c74fad429b6 (target/rx: Dump bytes for each insn during 
disassembly)
24/24 Checking commit 8c36c53a15ff (target/rx: Remove suffix in cpu class.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden