[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/42] target/arm: Convert VCVTA/VCVTN/VCVTP/VCV
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 09/42] target/arm: Convert VCVTA/VCVTN/VCVTP/VCVTM to decodetree |
Date: |
Fri, 7 Jun 2019 10:38:14 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/6/19 12:45 PM, Peter Maydell wrote:
> @@ -3452,6 +3446,15 @@ static int disas_vfp_insn(DisasContext *s, uint32_t
> insn)
> }
> }
>
> + if (extract32(insn, 28, 4) == 0xf) {
> + /*
> + * Encodings with T=1 (Thumb) or unconditional (ARM): these
> + * were all handled by the decodetree decoder, so any insn
> + * patterns which get here must be UNDEF.
> + */
> + return 1;
> + }
This could be merged into the previous IF. Unless I'm jumping the gun and this
too goes away at the end after everything is converted?
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [Qemu-devel] [PATCH 38/42] target/arm: Convert integer-to-float insns to decodetree, (continued)
- [Qemu-devel] [PATCH 26/42] target/arm: Convert VDIV to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 14/42] target/arm: Convert VFP two-register transfer insns to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 29/42] target/arm: Convert VABS to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 21/42] target/arm: Convert VFP VNMLA to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 09/42] target/arm: Convert VCVTA/VCVTN/VCVTP/VCVTM to decodetree, Peter Maydell, 2019/06/06
- Re: [Qemu-devel] [PATCH 09/42] target/arm: Convert VCVTA/VCVTN/VCVTP/VCVTM to decodetree,
Richard Henderson <=
- [Qemu-devel] [PATCH 17/42] target/arm: Remove VLDR/VSTR/VLDM/VSTM use of cpu_F0s and cpu_F0d, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 02/42] target/arm: Add stubs for AArch32 VFP decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 12/42] target/arm: Convert "double-precision" register moves to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 40/42] target/arm: Convert VCVT fp/fixed-point conversion insns to decodetree, Peter Maydell, 2019/06/06
- [Qemu-devel] [PATCH 19/42] target/arm: Convert VFP VMLS to decodetree, Peter Maydell, 2019/06/06