[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 51/52] gdbstub: Clear unused variables in gdb_handle_
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PULL 51/52] gdbstub: Clear unused variables in gdb_handle_packet |
Date: |
Fri, 7 Jun 2019 10:05:50 +0100 |
From: Jon Doron <address@hidden>
Signed-off-by: Jon Doron <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
diff --git a/gdbstub.c b/gdbstub.c
index 26c0c30682..12671e6e11 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -2284,17 +2284,11 @@ static void handle_target_halt(GdbCmdContext *gdb_ctx,
void *user_ctx)
static int gdb_handle_packet(GDBState *s, const char *line_buf)
{
- const char *p;
- int ch;
- uint8_t mem_buf[MAX_PACKET_LENGTH];
- char buf[sizeof(mem_buf) + 1 /* trailing NUL */];
const GdbCmdParseEntry *cmd_parser = NULL;
trace_gdbstub_io_command(line_buf);
- p = line_buf;
- ch = *p++;
- switch(ch) {
+ switch (line_buf[0]) {
case '!':
put_packet(s, "OK");
break;
@@ -2511,8 +2505,7 @@ static int gdb_handle_packet(GDBState *s, const char
*line_buf)
break;
default:
/* put empty packet */
- buf[0] = '\0';
- put_packet(s, buf);
+ put_packet(s, "");
break;
}
--
2.20.1
- [Qemu-devel] [PULL 38/52] gdbstub: Implement set_thread (H pkt) with new infra, (continued)
- [Qemu-devel] [PULL 38/52] gdbstub: Implement set_thread (H pkt) with new infra, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 01/52] editorconfig: add setting for shell scripts, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 03/52] tests/docker: Update the Fedora image to Fedora 30, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 06/52] .travis.yml: bump gcc sanitiser job to gcc-9, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 02/52] qemu-io-cmds: use clock_gettime for benchmarking, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 07/52] .travis.yml: add clang ubsan job, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 10/52] tests/vm: Fix build-centos docker-based tests run, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 11/52] tests/vm: Add missing variables on help, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 17/52] tests/vm: proper guest shutdown, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 42/52] gdbstub: Implement write memory (M pkt) with new infra, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 51/52] gdbstub: Clear unused variables in gdb_handle_packet,
Alex Bennée <=
- [Qemu-devel] [PULL 20/52] tests/vm: serial console support helpers, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 32/52] cputlb: cast size_t to target_ulong before using for address masks, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 15/52] tests/vm: use ssh with pty unconditionally, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 30/52] tests/tcg/x86_64: add a PVH crt.o for x86_64 system tests, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 23/52] tests/vm: netbsd autoinstall, using serial console, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 26/52] semihosting: split console_out into string and char versions, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 45/52] gdbstub: Implement read all registers (g pkt) with new infra, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 29/52] tests/tcg: clean-up VPATH/TESTS for i386, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 40/52] gdbstub: Implement set register (P pkt) with new infra, Alex Bennée, 2019/06/07
- [Qemu-devel] [PULL 18/52] tests/vm: add vm-boot-{ssh, serial}-<guest> targets, Alex Bennée, 2019/06/07