[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks |
Date: |
Fri, 07 Jun 2019 10:25:16 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 23/05/19 18:14, Markus Armbruster wrote:
>> * Machine core (Eduardo, Marcel)
>>
>> query-machines, query-current-machine,
>>
>> ~60 lines. Hardly worthwhile from a "let's shrink misc.json" point of
>> view. Might be worthwhile from a "let's make get_maintainers.pl
>> work".
>>
>> * CPUs (Paolo, Richard)
>>
>> query-cpus, query-cpus-fast
>>
>> ~300 lines. The commands are implemented in cpus.c, which MAINTAINERS
>> covers both under "Main loop" and under "Guest CPU cores (TCG) /
>> Overall". Neither feels right to me for these QMP commands.
>>
>> * NUMA (Eduardo)
>>
>> query-memdev, set-numa-node
>>
>> ~200 lines.
>
> I would move all three of these and add a new entry to MAINTAINERS.
Double-checking: do you propose to move all three to a single new QAPI
module, with a new MAINTAINERS entry covering just the new QAPI module?
If yes, care to propose a QAPI module file name, a MAINTAINERS head
line, and maintainers?
Or do you propose to create three QAPI modules machine.json, cpus.json,
numa.json, with machine.json filed in MAINTAINERS under "Machine core",
numa.json under "NUMA", and cpus.json under a new entry?