[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migratioin/ram.c: reset complete_round when we
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH] migratioin/ram.c: reset complete_round when we gets a queued page |
Date: |
Wed, 5 Jun 2019 14:41:08 +0800 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Wed, Jun 05, 2019 at 09:08:28AM +0800, Wei Yang wrote:
> In case we gets a queued page, the order of block is interrupted. We may
> not rely on the complete_round flag to say we have already searched the
> whole blocks on the list.
>
> Signed-off-by: Wei Yang <address@hidden>
> ---
> migration/ram.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index d881981876..e9b40d636d 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -2290,6 +2290,12 @@ static bool get_queued_page(RAMState *rs,
> PageSearchStatus *pss)
> */
> pss->block = block;
> pss->page = offset >> TARGET_PAGE_BITS;
> +
> + /*
> + * This unqueued page would break the "one round" check, even is
> + * really rare.
Why this is needed? Could you help explain the problem first?
Thanks,
--
Peter Xu
Re: [Qemu-devel] [PATCH] migratioin/ram.c: reset complete_round when we gets a queued page, Philippe Mathieu-Daudé, 2019/06/05