Re: [Qemu-devel] [PATCH v4 00/39] tcg: Move the softmmu tlb to CPUNegativeOffsetState

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v4 00/39] tcg: Move the softmmu tlb to 
CPUNegativeOffsetState
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
34ca5e59cf tcg/arm: Remove mostly unreachable tlb special case
ee91d825c0 tcg/arm: Use LDRD to load tlb mask+table
bb914609c4 tcg/aarch64: Use LDP to load tlb mask+table
d5e0e07dc6 cpu: Remove CPU_COMMON
ca07be8330 cpu: Move the softmmu tlb to CPUNegativeOffsetState
a2cb37619b cpu: Move icount_decr to CPUNegativeOffsetState
d11a129e9d cpu: Introduce CPUNegativeOffsetState
12cbf771a8 cpu: Introduce cpu_set_cpustate_pointers
0c0750e146 cpu: Move ENV_OFFSET to exec/gen-icount.h
0809633b52 target/xtensa: Use env_cpu, env_archcpu
2ba9bede59 target/unicore32: Use env_cpu, env_archcpu
c802794589 target/tricore: Use env_cpu
7e77be84ff target/tilegx: Use env_cpu
210e912bdc target/sparc: Use env_cpu, env_archcpu
63cb2560bd target/sh4: Use env_cpu, env_archcpu
22a8ff9cf7 target/s390x: Use env_cpu, env_archcpu
9659df970c target/riscv: Use env_cpu, env_archcpu
1f71f602af target/ppc: Use env_cpu, env_archcpu
1a69394a8b target/openrisc: Use env_cpu, env_archcpu
e4e737444b target/nios2: Use env_cpu, env_archcpu
ad91fa41eb target/moxie: Use env_cpu, env_archcpu
f1361daf5f target/mips: Use env_cpu, env_archcpu
b55814b165 target/microblaze: Use env_cpu, env_archcpu
b3318dd59b target/m68k: Use env_cpu, env_archcpu
cd2261bc71 target/lm32: Use env_cpu, env_archcpu
0006be4726 target/i386: Use env_cpu, env_archcpu
25a471ecc2 target/hppa: Use env_cpu, env_archcpu
d903061de8 target/cris: Use env_cpu, env_archcpu
3c7a60c9af target/cris: Reindent op_helper.c
f32a7110b5 target/cris: Reindent mmu.c
48a0d4196e target/arm: Use env_cpu, env_archcpu
838a1e1bf6 target/alpha: Use env_cpu, env_archcpu
7f61606912 cpu: Introduce env_archcpu
fc29f50705 cpu: Replace ENV_GET_CPU with env_cpu
02881b40d1 cpu: Define ArchCPU
c0947fa0bf cpu: Define CPUArchState with typedef
5f1fb21fa9 tcg: Create struct CPUTLB
56021e134e tcg: Split out target/arch/cpu-param.h
2ee12a2303 tcg: Fold CPUTLBWindow into CPUTLBDesc

=== OUTPUT BEGIN ===
1/39 Checking commit 2ee12a2303f6 (tcg: Fold CPUTLBWindow into CPUTLBDesc)
2/39 Checking commit 56021e134eef (tcg: Split out target/arch/cpu-param.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#57: 
new file mode 100644

total: 0 errors, 1 warnings, 1290 lines checked

Patch 2/39 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/39 Checking commit 5f1fb21fa917 (tcg: Create struct CPUTLB)
4/39 Checking commit c0947fa0bfa5 (cpu: Define CPUArchState with typedef)
5/39 Checking commit 02881b40d194 (cpu: Define ArchCPU)
6/39 Checking commit fc29f50705f4 (cpu: Replace ENV_GET_CPU with env_cpu)
7/39 Checking commit 7f6160691235 (cpu: Introduce env_archcpu)
8/39 Checking commit 838a1e1bf644 (target/alpha: Use env_cpu, env_archcpu)
9/39 Checking commit 48a0d4196e93 (target/arm: Use env_cpu, env_archcpu)
10/39 Checking commit f32a7110b524 (target/cris: Reindent mmu.c)
11/39 Checking commit 3c7a60c9af21 (target/cris: Reindent op_helper.c)
12/39 Checking commit d903061de8de (target/cris: Use env_cpu, env_archcpu)
13/39 Checking commit 25a471ecc229 (target/hppa: Use env_cpu, env_archcpu)
14/39 Checking commit 0006be472653 (target/i386: Use env_cpu, env_archcpu)
15/39 Checking commit cd2261bc7168 (target/lm32: Use env_cpu, env_archcpu)
16/39 Checking commit b3318dd59b84 (target/m68k: Use env_cpu, env_archcpu)
17/39 Checking commit b55814b165bf (target/microblaze: Use env_cpu, env_archcpu)
18/39 Checking commit f1361daf5ff3 (target/mips: Use env_cpu, env_archcpu)
19/39 Checking commit ad91fa41eb58 (target/moxie: Use env_cpu, env_archcpu)
20/39 Checking commit e4e737444b86 (target/nios2: Use env_cpu, env_archcpu)
21/39 Checking commit 1a69394a8b6f (target/openrisc: Use env_cpu, env_archcpu)
22/39 Checking commit 1f71f602afbc (target/ppc: Use env_cpu, env_archcpu)
23/39 Checking commit 9659df970c05 (target/riscv: Use env_cpu, env_archcpu)
24/39 Checking commit 22a8ff9cf7fa (target/s390x: Use env_cpu, env_archcpu)
25/39 Checking commit 63cb2560bd5a (target/sh4: Use env_cpu, env_archcpu)
26/39 Checking commit 210e912bdcba (target/sparc: Use env_cpu, env_archcpu)
27/39 Checking commit 7e77be84ff73 (target/tilegx: Use env_cpu)
28/39 Checking commit c802794589b8 (target/tricore: Use env_cpu)
29/39 Checking commit 2ba9bede5907 (target/unicore32: Use env_cpu, env_archcpu)
30/39 Checking commit 0809633b5295 (target/xtensa: Use env_cpu, env_archcpu)
31/39 Checking commit 0c0750e146eb (cpu: Move ENV_OFFSET to exec/gen-icount.h)
32/39 Checking commit 12cbf771a8f2 (cpu: Introduce cpu_set_cpustate_pointers)
33/39 Checking commit d11a129e9da7 (cpu: Introduce CPUNegativeOffsetState)
34/39 Checking commit a2cb37619bec (cpu: Move icount_decr to 
CPUNegativeOffsetState)
ERROR: return is not a function, parentheses are not required
#193: FILE: cpus.c:242:
+    return (cpu->icount_budget -

total: 1 errors, 0 warnings, 326 lines checked

Patch 34/39 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

35/39 Checking commit ca07be8330b6 (cpu: Move the softmmu tlb to 
CPUNegativeOffsetState)
36/39 Checking commit d5e0e07dc61d (cpu: Remove CPU_COMMON)
37/39 Checking commit bb914609c43a (tcg/aarch64: Use LDP to load tlb mask+table)
38/39 Checking commit ee91d825c033 (tcg/arm: Use LDRD to load tlb mask+table)
39/39 Checking commit 34ca5e59cfd4 (tcg/arm: Remove mostly unreachable tlb 
special case)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden