[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [libvirt patch] qemu: adds support for virtfs 9p argume
From: |
Christian Schoenebeck |
Subject: |
Re: [Qemu-devel] [libvirt patch] qemu: adds support for virtfs 9p argument 'vii' |
Date: |
Mon, 03 Jun 2019 11:17:22 +0200 |
On Montag, 3. Juni 2019 08:57:15 CEST Greg Kurz wrote:
> > Ok, I will extend Antonios' patch to log that error on host. I thought
> > about limiting that error message to once per session (for not flooding
> > the logs), but it is probably not worth it, so if you don't veto then I
> > will just log that error simply on every file access.
>
> Please use error_report_once().
I will.
> > > Please repost a series, possibly based on some of Antonios's patches
> > > that
> > > allows to avoid the QID collision, returns an error to the client
> > > instead
> > > and possibly printing out some useful messages in the QEMU log. Then, on
> > > top of that, you can start introducing hashing and variable prefix
> > > length.
> >
> > So you want that as its own patch series first, or can I continue with my
> > suggestion to deliver the hash patch and variable suffix length patch as
> > last patches within the same series?
>
> Same series is okay.
Ok.
I'm currently busy with other work; I will probably send a new patch set
approximately next week.
Best regards,
Christian Schoenebeck