Re: [Qemu-devel] [PATCH v1 07/23] s390x/tcg: Implement VECTOR FP CONVERT FROM FIXED 64-BIT

[David Hildenbrand]

On 31.05.19 19:15, Richard Henderson wrote:
> On 5/31/19 12:10 PM, Richard Henderson wrote:
>> On 5/31/19 5:44 AM, David Hildenbrand wrote:
>>> +static DisasJumpType op_vcdg(DisasContext *s, DisasOps *o)
>>> +{
>>> +    const uint8_t fpf = get_field(s->fields, m3);
>>> +    const uint8_t m4 = get_field(s->fields, m4);
>>> +    const uint8_t erm = get_field(s->fields, m5);
>>> +    const bool se = extract32(m4, 3, 1);
>>> +    gen_helper_gvec_2_ptr *fn;
>>> +
>>> +    if (fpf != FPF_LONG || extract32(m4, 0, 2) || erm > 7 || erm == 2) {
>>
>> Please split out the erm validity check.
>> We have fpinst_extract_m34 doing some of this now;
>> it would be a shame to replicate it more.
> 
> Hmm.  Or perhaps you aren't replicating it because it's only used by these
> conversions, and both signed and unsigned go through this same function?

Right, the check is only at one place in this file. Thanks!

> 
> Reviewed-by: Richard Henderson <address@hidden>
> 
> 
> r~
> 
> 


-- 

Thanks,

David / dhildenb