Re: [Qemu-devel] [PATCH v3 02/12] migration: No need to take rcu during

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 02/12] migration: No need to take rcu during

From:	Juan Quintela
Subject:	Re: [Qemu-devel] [PATCH v3 02/12] migration: No need to take rcu during sync_dirty_bitmap
Date:	Fri, 31 May 2019 14:58:43 +0200
User-agent:	Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)

Peter Xu <address@hidden> wrote:
> cpu_physical_memory_sync_dirty_bitmap() has one RAMBlock* as
> parameter, which means that it must be with RCU read lock held
> already.  Taking it again inside seems redundant.  Removing it.
> Instead comment on the functions about the RCU read lock.

Anyways, hotplug/unplug is suppossed to be disable during migration.  If
we add/remove a ramblock during migration bad things could happen.

Later, Juan.

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-devel] [PATCH v3 00/12] kvm/migration: support KVM_CLEAR_DIRTY_LOG, Peter Xu, 2019/05/30
- [Qemu-devel] [PATCH v3 01/12] checkpatch: Allow SPDX-License-Identifier, Peter Xu, 2019/05/30
  - Re: [Qemu-devel] [PATCH v3 01/12] checkpatch: Allow SPDX-License-Identifier, Juan Quintela, 2019/05/31
- [Qemu-devel] [PATCH v3 02/12] migration: No need to take rcu during sync_dirty_bitmap, Peter Xu, 2019/05/30
  - Re: [Qemu-devel] [PATCH v3 02/12] migration: No need to take rcu during sync_dirty_bitmap, Juan Quintela <=
  - Re: [Qemu-devel] [PATCH v3 02/12] migration: No need to take rcu during sync_dirty_bitmap, Juan Quintela, 2019/05/31
- [Qemu-devel] [PATCH v3 03/12] memory: Remove memory_region_get_dirty(), Peter Xu, 2019/05/30
  - Re: [Qemu-devel] [PATCH v3 03/12] memory: Remove memory_region_get_dirty(), Juan Quintela, 2019/05/31
- [Qemu-devel] [PATCH v3 04/12] memory: Don't set migration bitmap when without migration, Peter Xu, 2019/05/30
  - Re: [Qemu-devel] [PATCH v3 04/12] memory: Don't set migration bitmap when without migration, Juan Quintela, 2019/05/31
    - Re: [Qemu-devel] [PATCH v3 04/12] memory: Don't set migration bitmap when without migration, Peter Xu, 2019/05/31
- [Qemu-devel] [PATCH v3 05/12] bitmap: Add bitmap_copy_with_{src|dst}_offset(), Peter Xu, 2019/05/30
  - Re: [Qemu-devel] [PATCH v3 05/12] bitmap: Add bitmap_copy_with_{src|dst}_offset(), Dr. David Alan Gilbert, 2019/05/30
    - Re: [Qemu-devel] [PATCH v3 05/12] bitmap: Add bitmap_copy_with_{src|dst}_offset(), Peter Xu, 2019/05/30
- [Qemu-devel] [PATCH v3 06/12] memory: Pass mr into snapshot_and_clear_dirty, Peter Xu, 2019/05/30

Prev by Date: Re: [Qemu-devel] [PATCH v3 03/12] memory: Remove memory_region_get_dirty()
Next by Date: Re: [Qemu-devel] [PATCH v3 02/12] migration: No need to take rcu during sync_dirty_bitmap
Previous by thread: [Qemu-devel] [PATCH v3 02/12] migration: No need to take rcu during sync_dirty_bitmap
Next by thread: Re: [Qemu-devel] [PATCH v3 02/12] migration: No need to take rcu during sync_dirty_bitmap
Index(es):
- Date
- Thread