Re: [Qemu-devel] [PULL 10/25] util: Add qemu_guest_getrandom and associated routines

[Peter Maydell]

On Wed, 22 May 2019 at 19:42, Richard Henderson
<address@hidden> wrote:
>
> This routine is intended to produce high-quality random numbers to the
> guest.  Normally, such numbers are crypto quality from the host, but a
> command-line option can force the use of a fully deterministic sequence
> for use while debugging.

> +void qemu_guest_getrandom_nofail(void *buf, size_t len)
> +{
> +    qemu_guest_getrandom(buf, len, &error_fatal);
> +}
>

Hi; Coverity complains about this because in the other 4 places
where we call qemu_guest_getrandom() we check its return
value, but here we ignore it. If qemu_guest_getrandom() can't
fail ever then we don't need the separate _nofail() version.
If it can fail sometimes but not here then we should assert()
so with a comment explaining why it can't fail, or we should
do an error-exit check like qdev_init_nofail().
(This is CID 1401701.)

thanks
-- PMM