[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] hw/block/fdc: floppy command FIFO memory ini
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] hw/block/fdc: floppy command FIFO memory initialization |
|
Date: |
Wed, 29 May 2019 23:38:44 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 29.05.19 20:20, Andrey Shinkevich wrote:
> The uninitialized memory allocated for the command FIFO of the
> floppy controller during the VM hardware initialization incurs
> many unwanted reports by Valgrind when VM state is being saved.
> That verbosity hardens a search for the real memory issues when
> the iotests run. Particularly, the patch eliminates 20 unnecessary
> reports of the Valgrind tool in the iotest #169.
>
> Signed-off-by: Andrey Shinkevich <address@hidden>
> ---
> v2:
> 01: The pointer unnecessary check 'if (fdctrl->fifo)' was removed
> as suggested by John.
>
> hw/block/fdc.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to my block-on-kevin branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block-on-kevin
(To become my block branch when my current pull request is done.)
Max
signature.asc
Description: OpenPGP digital signature