Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

[Markus Armbruster]

Philippe Mathieu-Daudé <address@hidden> writes:

> On 5/29/19 5:08 PM, Markus Armbruster wrote:
>> When scripts/get_maintainer.pl reports something like
>> 
>>     John Doe <address@hidden> (maintainer:Overall)
>> 
>> the user is left to wonder *which* of our three "Overall" sections
>> applies.  We have three, one each under "Guest CPU cores (TCG)",
>> "Guest CPU Cores (KVM)", and "Overall usermode emulation".
>> 
>> Rename sections under
>> 
>> * "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"
>> 
>> * "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"
>> 
>> * "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"
>> 
>> * "Architecture support" from "FOO" to "FOO general architecture
>>   support"
>> 
>> * "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"
>
> I find the "cores" pattern more confusing now :S

Then let's find less confusing headlines together.

>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
>>  1 file changed, 39 insertions(+), 39 deletions(-)
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index edc260e503..196282d165 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -83,7 +83,7 @@ T: git https://github.com/vivier/qemu.git trivial-patches
>>  
>>  Architecture support
>>  --------------------
>> -S390
>> +S390 general architecture support
>
> OK
>
>>  M: Cornelia Huck <address@hidden>
>>  S: Supported
>>  F: default-configs/s390x-softmmu.mak
>> @@ -108,7 +108,7 @@ L: address@hidden
>>  
>>  Guest CPU cores (TCG):
>>  ----------------------
>> -Overall
>> +Overall CPU cores (TCG)
>
> What about "TCG (Overall)"?

Could be confused with the stuff under "Tiny Code Generator (TCG)"
below.

"Overall CPUs (TCG)"?

"TCG CPUs (overall)"?

>>  M: Richard Henderson <address@hidden>
>>  R: Paolo Bonzini <address@hidden>
>>  S: Maintained
>> @@ -133,14 +133,14 @@ F: fpu/
>>  F: include/fpu/
>>  F: tests/fp/
>>  
>> -Alpha
>> +Alpha CPU cores (TCG)
>
> I find "cores" confusing here, why not use "Alpha CPU (TCG)"?

"Alpha CPUs (TCG)"?

"TCG Alpha CPUs"?

Same for KVM and Xen below.

>>  M: Richard Henderson <address@hidden>
>>  S: Maintained
>>  F: target/alpha/
>>  F: tests/tcg/alpha/
>>  F: disas/alpha.c
>>  
>> -ARM
>> +ARM CPU cores (TCG)
>
> Ditto.
>
>>  M: Peter Maydell <address@hidden>
>>  L: address@hidden
>>  S: Maintained
>> @@ -161,7 +161,7 @@ S: Maintained
>>  F: hw/arm/smmu*
>>  F: include/hw/arm/smmu*
>>  
>> -CRIS
>> +CRIS CPU cores (TCG)
>>  M: Edgar E. Iglesias <address@hidden>
>>  S: Maintained
>>  F: target/cris/
>> @@ -170,14 +170,14 @@ F: include/hw/cris/
>>  F: tests/tcg/cris/
>>  F: disas/cris.c
>>  
>> -HPPA (PA-RISC)
>> +HPPA (PA-RISC) CPU cores (TCG)
>>  M: Richard Henderson <address@hidden>
>>  S: Maintained
>>  F: target/hppa/
>>  F: hw/hppa/
>>  F: disas/hppa.c
>>  
>> -LM32
>> +LM32 CPU cores (TCG)
>>  M: Michael Walle <address@hidden>
>>  S: Maintained
>>  F: target/lm32/
>> @@ -190,20 +190,20 @@ F: include/hw/char/lm32_juart.h
>>  F: include/hw/lm32/
>>  F: tests/tcg/lm32/
>>  
>> -M68K
>> +M68K CPU cores (TCG)
>>  M: Laurent Vivier <address@hidden>
>>  S: Maintained
>>  F: target/m68k/
>>  F: disas/m68k.c
>>  
>> -MicroBlaze
>> +MicroBlaze CPU cores (TCG)
>>  M: Edgar E. Iglesias <address@hidden>
>>  S: Maintained
>>  F: target/microblaze/
>>  F: hw/microblaze/
>>  F: disas/microblaze.c
>>  
>> -MIPS
>> +MIPS CPU cores (TCG)
>>  M: Aurelien Jarno <address@hidden>
>>  M: Aleksandar Markovic <address@hidden>
>>  R: Aleksandar Rikalo <address@hidden>
>> @@ -224,7 +224,7 @@ F: include/hw/timer/mips_gictimer.h
>>  F: tests/tcg/mips/
>>  K: ^Subject:.*(?i)mips
>>  
>> -Moxie
>> +Moxie CPU cores (TCG)
>>  M: Anthony Green <address@hidden>
>>  S: Maintained
>>  F: target/moxie/
>> @@ -232,7 +232,7 @@ F: disas/moxie.c
>>  F: hw/moxie/
>>  F: default-configs/moxie-softmmu.mak
>>  
>> -NiosII
>> +NiosII CPU cores (TCG)
>>  M: Chris Wulff <address@hidden>
>>  M: Marek Vasut <address@hidden>
>>  S: Maintained
>> @@ -242,14 +242,14 @@ F: hw/intc/nios2_iic.c
>>  F: disas/nios2.c
>>  F: default-configs/nios2-softmmu.mak
>>  
>> -OpenRISC
>> +OpenRISC CPU cores (TCG)
>>  M: Stafford Horne <address@hidden>
>>  S: Odd Fixes
>>  F: target/openrisc/
>>  F: hw/openrisc/
>>  F: tests/tcg/openrisc/
>>  
>> -PowerPC
>> +PowerPC CPU cores (TCG)
>>  M: David Gibson <address@hidden>
>>  L: address@hidden
>>  S: Maintained
>> @@ -258,7 +258,7 @@ F: hw/ppc/
>>  F: include/hw/ppc/
>>  F: disas/ppc.c
>>  
>> -RISC-V
>> +RISC-V CPU cores (TCG)
>>  M: Palmer Dabbelt <address@hidden>
>>  M: Alistair Francis <address@hidden>
>>  M: Sagar Karandikar <address@hidden>
>> @@ -271,7 +271,7 @@ F: include/hw/riscv/
>>  F: linux-user/host/riscv32/
>>  F: linux-user/host/riscv64/
>>  
>> -S390
>> +S390 CPU cores (TCG)
>>  M: Richard Henderson <address@hidden>
>>  M: David Hildenbrand <address@hidden>
>>  S: Maintained
>> @@ -281,7 +281,7 @@ F: disas/s390.c
>>  F: tests/tcg/s390x/
>>  L: address@hidden
>>  
>> -SH4
>> +SH4 CPU cores (TCG)
>>  M: Aurelien Jarno <address@hidden>
>>  S: Odd Fixes
>>  F: target/sh4/
>> @@ -289,7 +289,7 @@ F: hw/sh4/
>>  F: disas/sh4.c
>>  F: include/hw/sh4/
>>  
>> -SPARC
>> +SPARC CPU cores (TCG)
>>  M: Mark Cave-Ayland <address@hidden>
>>  M: Artyom Tarasenko <address@hidden>
>>  S: Maintained
>> @@ -299,14 +299,14 @@ F: hw/sparc64/
>>  F: include/hw/sparc/sparc64.h
>>  F: disas/sparc.c
>>  
>> -UniCore32
>> +UniCore32 CPU cores (TCG)
>>  M: Guan Xuetao <address@hidden>
>>  S: Maintained
>>  F: target/unicore32/
>>  F: hw/unicore32/
>>  F: include/hw/unicore32/
>>  
>> -X86
>> +X86 CPU cores (TCG)
>>  M: Paolo Bonzini <address@hidden>
>>  M: Richard Henderson <address@hidden>
>>  M: Eduardo Habkost <address@hidden>
>> @@ -319,7 +319,7 @@ F: disas/i386.c
>>  F: docs/qemu-cpu-models.texi
>>  T: git https://github.com/ehabkost/qemu.git x86-next
>>  
>> -Xtensa
>> +Xtensa CPU cores (TCG)
>>  M: Max Filippov <address@hidden>
>>  W: http://wiki.osll.ru/doku.php?id=etc:users:jcmvbkbc:qemu-target-xtensa
>>  S: Maintained
>> @@ -330,7 +330,7 @@ F: disas/xtensa.c
>>  F: include/hw/xtensa/xtensa-isa.h
>>  F: default-configs/xtensa*.mak
>>  
>> -TriCore
>> +TriCore CPU cores (TCG)
>>  M: Bastian Koppelmann <address@hidden>
>>  S: Maintained
>>  F: target/tricore/
>> @@ -345,7 +345,7 @@ F: tests/tcg/multiarch/
>>  Guest CPU Cores (KVM):
>>  ----------------------
>>  
>> -Overall
>> +Overall CPU cores (KVM)
>
> "KVM (Overall)"?
>
>>  M: Paolo Bonzini <address@hidden>
>>  L: address@hidden
>>  S: Supported
>> @@ -356,24 +356,24 @@ F: include/hw/kvm/
>>  F: include/sysemu/kvm*.h
>>  F: scripts/kvm/kvm_flightrecorder
>>  
>> -ARM
>> +ARM CPU cores (KVM)
>
> "ARM CPU (KVM)"?
>
>>  M: Peter Maydell <address@hidden>
>>  L: address@hidden
>>  S: Maintained
>>  F: target/arm/kvm.c
>>  
>> -MIPS
>> +MIPS CPU cores (KVM)
>>  M: James Hogan <address@hidden>
>>  R: Aleksandar Rikalo <address@hidden>
>>  S: Maintained
>>  F: target/mips/kvm.c
>>  
>> -PPC
>> +PPC CPU cores (KVM)
>>  M: David Gibson <address@hidden>
>>  S: Maintained
>>  F: target/ppc/kvm.c
>>  
>> -S390
>> +S390 CPU cores (KVM)
>>  M: Halil Pasic <address@hidden>
>>  M: Cornelia Huck <address@hidden>
>>  M: Christian Borntraeger <address@hidden>
>> @@ -392,7 +392,7 @@ T: git https://github.com/cohuck/qemu.git s390-next
>>  T: git https://github.com/borntraeger/qemu.git s390-next
>>  L: address@hidden
>>  
>> -X86
>> +X86 CPU cores (KVM)
>>  M: Paolo Bonzini <address@hidden>
>>  M: Marcelo Tosatti <address@hidden>
>>  L: address@hidden
>> @@ -403,7 +403,7 @@ F: scripts/kvm/vmxcap
>>  Guest CPU Cores (Xen):
>>  ----------------------
>>  
>> -X86
>> +X86 CPU cores (Xen)
>>  M: Stefano Stabellini <address@hidden>
>>  M: Anthony Perard <address@hidden>
>>  M: Paul Durrant <address@hidden>
>> @@ -2256,7 +2256,7 @@ F: tests/uefi-test-tools/
>>  
>>  Usermode Emulation
>>  ------------------
>> -Overall
>> +Overall usermode emulation
>
> "Usermode Emulation (Overall)"?

Works for me.

>>  M: Riku Voipio <address@hidden>
>>  S: Maintained
>>  F: thunk.c
>> @@ -2282,7 +2282,7 @@ M: Richard Henderson <address@hidden>

Missed one:

    Tiny Code Generator (TCG)
    -------------------------
    Common code

Something like "TCG common code" should do.

    M: Richard Henderson <address@hidden>
>>  S: Maintained
>>  F: tcg/
>>  
>> -AArch64 target
>> +AArch64 TCG target
>>  M: Claudio Fontana <address@hidden>
>>  M: Claudio Fontana <address@hidden>
>>  S: Maintained
>> @@ -2291,33 +2291,33 @@ F: tcg/aarch64/
>>  F: disas/arm-a64.cc
>>  F: disas/libvixl/
>>  
>> -ARM target
>> +ARM TCG target
>>  M: Andrzej Zaborowski <address@hidden>
>>  S: Maintained
>>  L: address@hidden
>>  F: tcg/arm/
>>  F: disas/arm.c
>>  
>> -i386 target
>> +i386 TCG target
>>  M: Richard Henderson <address@hidden>
>>  S: Maintained
>>  F: tcg/i386/
>>  F: disas/i386.c
>>  
>> -MIPS target
>> +MIPS TCG target
>>  M: Aurelien Jarno <address@hidden>
>>  R: Aleksandar Rikalo <address@hidden>
>>  S: Maintained
>>  F: tcg/mips/
>>  F: disas/mips.c
>>  
>> -PPC
>> +PPC TCG target
>>  M: Richard Henderson <address@hidden>
>>  S: Odd Fixes
>>  F: tcg/ppc/
>>  F: disas/ppc.c
>>  
>> -RISC-V
>> +RISC-V TCG target
>>  M: Palmer Dabbelt <address@hidden>
>>  M: Alistair Francis <address@hidden>
>>  L: address@hidden
>> @@ -2325,19 +2325,19 @@ S: Maintained
>>  F: tcg/riscv/
>>  F: disas/riscv.c
>>  
>> -S390 target
>> +S390 TCG target
>>  M: Richard Henderson <address@hidden>
>>  S: Maintained
>>  F: tcg/s390/
>>  F: disas/s390.c
>>  L: address@hidden
>>  
>> -SPARC target
>> +SPARC TCG target
>>  S: Odd Fixes
>>  F: tcg/sparc/
>>  F: disas/sparc.c
>>  
>> -TCI target
>> +TCI TCG target
>>  M: Stefan Weil <address@hidden>
>>  S: Maintained
>>  F: tcg/tci/
>>