[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v12 03/20] gdbstub: Implement thread_alive (T pkt) w
From: |
Jon Doron |
Subject: |
[Qemu-devel] [PATCH v12 03/20] gdbstub: Implement thread_alive (T pkt) with new infra |
Date: |
Wed, 29 May 2019 09:41:31 +0300 |
Signed-off-by: Jon Doron <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
---
gdbstub.c | 43 ++++++++++++++++++++++++++++++++-----------
1 file changed, 32 insertions(+), 11 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index 1db322c15a..7801f2f260 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1507,6 +1507,30 @@ static void handle_detach(GdbCmdContext *gdb_ctx, void
*user_ctx)
put_packet(s, "OK");
}
+static void handle_thread_alive(GdbCmdContext *gdb_ctx, void *user_ctx)
+{
+ CPUState *cpu;
+
+ if (!gdb_ctx->num_params) {
+ put_packet(gdb_ctx->s, "E22");
+ return;
+ }
+
+ if (gdb_ctx->params[0].thread_id.kind == GDB_READ_THREAD_ERR) {
+ put_packet(gdb_ctx->s, "E22");
+ return;
+ }
+
+ cpu = gdb_get_cpu(gdb_ctx->s, gdb_ctx->params[0].thread_id.pid,
+ gdb_ctx->params[0].thread_id.tid);
+ if (!cpu) {
+ put_packet(gdb_ctx->s, "E22");
+ return;
+ }
+
+ put_packet(gdb_ctx->s, "OK");
+}
+
static int gdb_handle_packet(GDBState *s, const char *line_buf)
{
CPUState *cpu;
@@ -1807,17 +1831,14 @@ static int gdb_handle_packet(GDBState *s, const char
*line_buf)
}
break;
case 'T':
- thread_kind = read_thread_id(p, &p, &pid, &tid);
- if (thread_kind == GDB_READ_THREAD_ERR) {
- put_packet(s, "E22");
- break;
- }
- cpu = gdb_get_cpu(s, pid, tid);
-
- if (cpu != NULL) {
- put_packet(s, "OK");
- } else {
- put_packet(s, "E22");
+ {
+ static const GdbCmdParseEntry thread_alive_cmd_desc = {
+ .handler = handle_thread_alive,
+ .cmd = "T",
+ .cmd_startswith = 1,
+ .schema = "t0"
+ };
+ cmd_parser = &thread_alive_cmd_desc;
}
break;
case 'q':
--
2.21.0
- [Qemu-devel] [PATCH v12 00/20] gdbstub: Refactor command packets handler, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 03/20] gdbstub: Implement thread_alive (T pkt) with new infra,
Jon Doron <=
- [Qemu-devel] [PATCH v12 01/20] gdbstub: Add infrastructure to parse cmd packets, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 02/20] gdbstub: Implement deatch (D pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 05/20] gdbstub: Implement continue with signal (C pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 07/20] gdbstub: Implement breakpoint commands (Z/z pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 04/20] gdbstub: Implement continue (c pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 06/20] gdbstub: Implement set_thread (H pkt) with new infra, Jon Doron, 2019/05/29
- [Qemu-devel] [PATCH v12 08/20] gdbstub: Implement set register (P pkt) with new infra, Jon Doron, 2019/05/29