[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] event_match: always match on None value
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2] event_match: always match on None value |
Date: |
Tue, 28 May 2019 21:35:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 28.05.19 20:38, John Snow wrote:
> Before, event_match didn't always recurse if the event value was not a
> dictionary, and would instead check for equality immediately.
>
> By delaying equality checking to post-recursion, we can allow leaf
> values like "5" to match "None" and take advantage of the generic
> None-returns-True clause.
>
> This makes the matching a little more obviously consistent at the
> expense of being able to check for explicit None values, which is
> probably not that important given what this function is used for.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> v2: actually let the for loop finish ... Thanks Max
> ---
> python/qemu/__init__.py | 24 ++++++++++++++----------
> 1 file changed, 14 insertions(+), 10 deletions(-)
Thanks, applied to my block-on-kevin branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block-on-kevin
...which is also the place where your backup/aio_context series
currently resides. I couldn’t put it in the pull request I just sent
because it depends on patches from Kevin’s branch.
But know that your patches aren’t forgotten!
Max
signature.asc
Description: OpenPGP digital signature