[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tests/migration: Disable /migration/postcopy/un
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH] tests/migration: Disable /migration/postcopy/unix qtest on Travis-CI |
Date: |
Tue, 28 May 2019 15:42:04 +0100 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
* Philippe Mathieu-Daudé (address@hidden) wrote:
> This started to fail 6 months ago [1] and lately occurs too
> often on the main Travis CI.
>
> Travis CI set the CONTINUOUS_INTEGRATION variable in the process
> environment [2]. Let's use it to disable it when running this test
> there.
>
> [1] https://travis-ci.org/philmd/qemu/jobs/466594203#L4430
> [2]
> https://docs.travis-ci.com/user/environment-variables/#default-environment-variables
I think the right solution here is to disable it under TCG.
Dave
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/migration-test.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index bd3f5c3125..c5091e1fb1 100644
> --- a/tests/migration-test.c
> +++ b/tests/migration-test.c
> @@ -764,6 +764,11 @@ static void test_postcopy(void)
> {
> QTestState *from, *to;
>
> + if (getenv("CONTINUOUS_INTEGRATION")) {
> + /* Test failing on Travis-CI */
> + g_test_skip("Running on Travis-CI");
> + }
> +
> if (migrate_postcopy_prepare(&from, &to, false)) {
> return;
> }
> --
> 2.20.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK