Re: [Qemu-devel] [PATCH 1/4] migration: multifd_save_setup always return 0

[Juan Quintela]

Wei Yang <address@hidden> wrote:
> Signed-off-by: Wei Yang <address@hidden>
> ---
>  migration/migration.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index d0a0f68f11..3aae4f2734 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -3336,12 +3336,7 @@ void migrate_fd_connect(MigrationState *s, Error 
> *error_in)
>          return;
>      }
>  
> -    if (multifd_save_setup() != 0) {
> -        migrate_set_state(&s->state, MIGRATION_STATUS_SETUP,
> -                          MIGRATION_STATUS_FAILED);
> -        migrate_fd_cleanup(s);
> -        return;
> -    }
> +    multifd_save_setup();
>      qemu_thread_create(&s->thread, "live_migration", migration_thread, s,
>                         QEMU_THREAD_JOINABLE);
>      s->migration_thread_running = true;

Nack.

On the compression patches that are on list, multifd_save_setup()
returns -1 if there is a problem when we allocate a zbuff.