Re: [Qemu-devel] [PATCH v11 02/20] gdbstub: Implement deatch (D pkt) with new infra

[Alex Bennée]

Alex Bennée <address@hidden> writes:

> Alex Bennée <address@hidden> writes:
>
>> Jon Doron <address@hidden> writes:
>>
>>> Signed-off-by: Jon Doron <address@hidden>
>>
>> Reviewed-by: Alex Bennée <address@hidden>
>
> Hmm although I bisected to this patch which fails on:
>
> 09:49 address@hidden/x86_64  [linux.git/address@hidden >gdb 
> ./builds/arm64/vmlinux -x ~/lsrc/qemu.git/tests/guest-debug/test-gdbstub.py
<snip>
> Connecting to remote
> 0x0000000040000000 in ?? ()
> Checking we can step the first few instructions
> warning: Invalid remote reply:
<snip>
>>>      }
>>> +
>>> +    if (cmd_parser) {
>>> +        /* helper will respond */
>>> +        process_string_cmd(s, NULL, line_buf, cmd_parser, 1);
>>> +    } else {
>>> +        /* unknown command, empty respone */
>>> +        put_packet(s, "");
>>> +    }
>>> +

We can't default to this empty response until we have converted the
table otherwise we get strangeness and double responses.

>>>      return RS_IDLE;
>>>  }


--
Alex Bennée