[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v4 5/7] tests: New make target check-source
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC v4 5/7] tests: New make target check-source |
Date: |
Fri, 24 May 2019 18:25:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 23/05/19 21:57, Markus Armbruster wrote:
>>> A large number of headers don't pass this test, by design or by
>>> accident. To keep things more manageable, exclude all headers outside
>>> include/ for now.
>> A lot of these, either in include/ or outside, are _meant_ to be
>> included many times. What about renaming those to .inc.h and
>> whitelisting them in the script?
> Yes, that would be nice.
Another suggestion: are there headers that cannot even be included once
(due to dependencies)? Is it worth including a test for those even in
the first iteration?
.inc.h files would skip that test too.
Paolo
- [Qemu-devel] [RFC v4 1/7] Makefile: Remove code to smooth transition to config.status, (continued)
Re: [Qemu-devel] [RFC v4 5/7] tests: New make target check-source, Philippe Mathieu-Daudé, 2019/05/24
[Qemu-devel] [RFC v4 6/7] tests: Don't limit check-headers to include/, Markus Armbruster, 2019/05/23