[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RISU v3 06/11] risu_i386: remove old unused code
From: |
Jan Bobek |
Subject: |
[Qemu-devel] [RISU v3 06/11] risu_i386: remove old unused code |
Date: |
Thu, 23 May 2019 16:44:04 -0400 |
The code being removed is a remnant of the past implementation; it has
since been replaced by its more powerful, architecture-independent
counterpart in reginfo.c.
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Jan Bobek <address@hidden>
---
risu_i386.c | 58 -----------------------------------------------------
1 file changed, 58 deletions(-)
diff --git a/risu_i386.c b/risu_i386.c
index 06d95e5..9962b8f 100644
--- a/risu_i386.c
+++ b/risu_i386.c
@@ -16,13 +16,6 @@
#include "risu.h"
#include "risu_reginfo_i386.h"
-struct reginfo master_ri, apprentice_ri;
-
-static int insn_is_ud2(uint32_t insn)
-{
- return ((insn & 0xffff) == 0x0b0f);
-}
-
void advance_pc(void *vuc)
{
ucontext_t *uc = (ucontext_t *) vuc;
@@ -57,54 +50,3 @@ uintptr_t get_pc(struct reginfo *ri)
{
return ri->gregs[REG_E(IP)];
}
-
-int send_register_info(int sock, void *uc)
-{
- struct reginfo ri;
- fill_reginfo(&ri, uc);
- return send_data_pkt(sock, &ri, sizeof(ri));
-}
-
-/* Read register info from the socket and compare it with that from the
- * ucontext. Return 0 for match, 1 for end-of-test, 2 for mismatch.
- * NB: called from a signal handler.
- */
-int recv_and_compare_register_info(int sock, void *uc)
-{
- int resp;
- fill_reginfo(&master_ri, uc);
- recv_data_pkt(sock, &apprentice_ri, sizeof(apprentice_ri));
- if (memcmp(&master_ri, &apprentice_ri, sizeof(master_ri)) != 0) {
- /* mismatch */
- resp = 2;
- } else if (insn_is_ud2(master_ri.faulting_insn)) {
- /* end of test */
- resp = 1;
- } else {
- /* either successful match or expected undef */
- resp = 0;
- }
- send_response_byte(sock, resp);
- return resp;
-}
-
-/* Print a useful report on the status of the last comparison
- * done in recv_and_compare_register_info(). This is called on
- * exit, so need not restrict itself to signal-safe functions.
- * Should return 0 if it was a good match (ie end of test)
- * and 1 for a mismatch.
- */
-int report_match_status(void)
-{
- fprintf(stderr, "match status...\n");
- fprintf(stderr, "master reginfo:\n");
- dump_reginfo(&master_ri);
- fprintf(stderr, "apprentice reginfo:\n");
- dump_reginfo(&apprentice_ri);
- if (memcmp(&master_ri, &apprentice_ri, sizeof(master_ri)) == 0) {
- fprintf(stderr, "match!\n");
- return 0;
- }
- fprintf(stderr, "mismatch!\n");
- return 1;
-}
--
2.20.1
- [Qemu-devel] [RISU v3 00/11] Support for i386/x86_64 with vector extensions, Jan Bobek, 2019/05/23
- [Qemu-devel] [RISU v3 01/11] Makefile: undefine the arch name symbol, Jan Bobek, 2019/05/23
- [Qemu-devel] [RISU v3 02/11] risu_i386: move reginfo_t and related defines to risu_reginfo_i386.h, Jan Bobek, 2019/05/23
- [Qemu-devel] [RISU v3 03/11] risu_i386: move reginfo-related code to risu_reginfo_i386.c, Jan Bobek, 2019/05/23
- [Qemu-devel] [RISU v3 04/11] risu_reginfo_i386: implement arch-specific reginfo interface, Jan Bobek, 2019/05/23
- [Qemu-devel] [RISU v3 06/11] risu_i386: remove old unused code,
Jan Bobek <=
- [Qemu-devel] [RISU v3 05/11] risu_i386: implement missing CPU-specific functions, Jan Bobek, 2019/05/23
- [Qemu-devel] [RISU v3 08/11] configure: add i386/x86_64 architectures, Jan Bobek, 2019/05/23
- [Qemu-devel] [RISU v3 10/11] risu_reginfo_i386: replace xfeature constants with symbolic names, Jan Bobek, 2019/05/23
- [Qemu-devel] [RISU v3 07/11] test_i386: change syntax from nasm to gas, Jan Bobek, 2019/05/23
- [Qemu-devel] [RISU v3 09/11] i386: Add avx512 state to reginfo_t, Jan Bobek, 2019/05/23
- [Qemu-devel] [RISU v3 11/11] risu_reginfo_i386: rework --xfeatures value parsing, Jan Bobek, 2019/05/23
- [Qemu-devel] [RISU PATCH] build-all-arches: include x86 triplets in the build, Alex Bennée, 2019/05/24