[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/3] qemu-img: rebase: Reuse parent BlockDriv
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/3] qemu-img: rebase: Reuse parent BlockDriverState |
Date: |
Thu, 23 May 2019 18:13:26 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 23.05.19 17:44, Sam Eiderman wrote:
> In safe mode we open the entire chain, including the parent backing
> file of the rebased file.
> Do not open a new BlockBackend for the parent backing file, which
> saves opening the rest of the chain twice, which for long chains
> saves many "pricy" bdrv_open() calls.
>
> Permissions for blk_new() were copied from blk_new_open() when
> flags = 0.
>
> Reviewed-by: Karl Heubaum <address@hidden>
> Reviewed-by: Eyal Moscovici <address@hidden>
> Signed-off-by: Sagi Amit <address@hidden>
> Co-developed-by: Sagi Amit <address@hidden>
> Signed-off-by: Sam Eiderman <address@hidden>
> ---
> qemu-img.c | 29 +++++++++--------------------
> 1 file changed, 9 insertions(+), 20 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature