Re: [Qemu-devel] [PULL 00/13] Add RX architecture

[Peter Maydell]

On Thu, 23 May 2019 at 16:30, <address@hidden> wrote:
>

> 3/13 Checking commit db39b054cd7e (target/rx: CPU definition)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #14:
> new file mode 100644
>
> ERROR: code indent should never use tabs
> #383: FILE: target/rx/cpu.h:137:
> +    qemu_irq ack;^I^I/* Interrupt acknowledge */$
>
> total: 1 errors, 1 warnings, 599 lines checked
>
> Patch 3/13 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.

> 5/13 Checking commit c06f2e7abea6 (hw/intc: RX62N interrupt controller (ICUa))
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #39:
> new file mode 100644
>
> ERROR: code indent should never use tabs
> #434: FILE: include/hw/intc/rx_icu.h:9:
> +    TRG_NEDGE = 1,^I/* Falling */$
>
> ERROR: code indent should never use tabs
> #435: FILE: include/hw/intc/rx_icu.h:10:
> +    TRG_PEDGE = 2,^I/* Raising */$
>
> ERROR: code indent should never use tabs
> #436: FILE: include/hw/intc/rx_icu.h:11:
> +    TRG_BEDGE = 3,^I/* Both */$
>
> total: 3 errors, 1 warnings, 442 lines checked

I'm not going to block the pull request just for a code style
issue, but it would be nice if you could send a followup patch
once this has landed that fixes the hard-coded tabs.

thanks
-- PMM