[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 06/28] target/arm: use the common interface f
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 06/28] target/arm: use the common interface for WRITE0/WRITEC in arm-semi |
Date: |
Thu, 23 May 2019 11:12:12 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/23/19 6:25 AM, Alex Bennée wrote:
> case TARGET_SYS_WRITEC:
> - {
> - char c;
> -
> - if (get_user_u8(c, args))
> - /* FIXME - should this error code be -TARGET_EFAULT ? */
> - return (uint32_t)-1;
> - /* Write to debug console. stderr is near enough. */
> - if (use_gdb_syscalls()) {
> - return arm_gdb_syscall(cpu, arm_semi_cb, "write,2,%x,1",
> args);
> - } else {
> - return write(STDERR_FILENO, &c, 1);
> - }
> - }
> + {
> + qemu_semihosting_console_out(env, args, 1);
> + return 0xdeadbeef;
> + }
> case TARGET_SYS_WRITE0:
You can drop the braces now that "char c" is gone,
which will then fix the indentation.
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH v2 00/28] current testing/next queue, Alex Bennée, 2019/05/23
- [Qemu-devel] [PATCH v2 02/28] semihosting: introduce CONFIG_SEMIHOSTING, Alex Bennée, 2019/05/23
- [Qemu-devel] [PATCH v2 06/28] target/arm: use the common interface for WRITE0/WRITEC in arm-semi, Alex Bennée, 2019/05/23
- Re: [Qemu-devel] [PATCH v2 06/28] target/arm: use the common interface for WRITE0/WRITEC in arm-semi,
Richard Henderson <=
- [Qemu-devel] [PATCH v2 01/28] semihosting: move semihosting configuration into its own directory, Alex Bennée, 2019/05/23
- [Qemu-devel] [PATCH v2 08/28] target/arm: correct return values for WRITE/READ in arm-semi, Alex Bennée, 2019/05/23
- [Qemu-devel] [PATCH v2 09/28] target/mips: only build mips-semi for softmmu, Alex Bennée, 2019/05/23
- [Qemu-devel] [PATCH v2 17/28] tests/tcg/aarch64: add system boot.S, Alex Bennée, 2019/05/23
- [Qemu-devel] [PATCH v2 11/28] MAINTAINERS: update for semihostings new home, Alex Bennée, 2019/05/23
- [Qemu-devel] [PATCH v2 03/28] semihosting: implement a semihosting console, Alex Bennée, 2019/05/23