[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] BootLinuxConsoleTest: Do not log empty line
From: |
Cleber Rosa |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] BootLinuxConsoleTest: Do not log empty lines |
Date: |
Thu, 23 May 2019 09:48:52 -0400 (EDT) |
----- Original Message -----
> From: "Philippe Mathieu-Daudé" <address@hidden>
> To: address@hidden
> Cc: "Eduardo Habkost" <address@hidden>, "Caio Carrara" <address@hidden>,
> "Alistair Francis"
> <address@hidden>, "Subbaraya Sundeep" <address@hidden>, address@hidden,
> "Cleber Rosa"
> <address@hidden>, "Peter Maydell" <address@hidden>, "Philippe Mathieu-Daudé"
> <address@hidden>
> Sent: Monday, May 20, 2019 6:06:34 PM
> Subject: [PATCH 1/2] BootLinuxConsoleTest: Do not log empty lines
>
> Avoid to log empty lines in console debug logs.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/acceptance/boot_linux_console.py | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/acceptance/boot_linux_console.py
> b/tests/acceptance/boot_linux_console.py
> index d5c500ea30..f593f3858e 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -37,8 +37,10 @@ class BootLinuxConsole(Test):
> console = self.vm.console_socket.makefile()
> console_logger = logging.getLogger('console')
> while True:
> - msg = console.readline()
> - console_logger.debug(msg.strip())
> + msg = console.readline().strip()
> + if not msg:
> + continue
> + console_logger.debug(msg)
> if success_message in msg:
> break
> if failure_message in msg:
> --
> 2.19.1
>
>
Reviewed-by: Cleber Rosa <address@hidden>