[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/7] virtio-pmem: add virtio device
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/7] virtio-pmem: add virtio device |
Date: |
Thu, 23 May 2019 08:21:29 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/23/19 5:24 AM, Pankaj Gupta wrote:
> This is the implementation of virtio-pmem device. Support will require
> machine changes for the architectures that will support it, so it will
> not yet be compiled. It can be unlocked with VIRTIO_PMEM_SUPPORTED per
> machine and disabled globally via VIRTIO_PMEM.
>
> We cannot use the "addr" property as that is already used e.g. for
> virtio-pci/pci devices. And we will have e.g. virtio-pmem-pci as a proxy.
> So we have to choose a different one (unfortunately). "memaddr" it is.
> That name should ideally be used by all other virtio-* based memory
> devices in the future.
> -device virtio-pmem-pci,id=p0,bus=bux0,addr=0x01,memaddr=0x1000000...
>
> Acked-by: Markus Armbruster <address@hidden>
> [ QAPI bits ]
> Signed-off-by: Pankaj Gupta <address@hidden>
> [ MemoryDevice/MemoryRegion changes, cleanups, addr property "memaddr",
> split up patches, unplug handler ]
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> +++ b/qapi/misc.json
> @@ -2742,16 +2742,42 @@
> }
> }
>
> +##
> +# @VirtioPMEMDeviceInfo:
> +#
> +# VirtioPMEM state information
> +#
> +# @id: device's ID
> +#
> +# @memaddr: physical address in memory, where device is mapped
> +#
> +# @size: size of memory that the device provides
> +#
> +# @memdev: memory backend linked with device
> +#
> +# Since: 4.0
You've missed 4.0; this should be 4.1.
> +##
> +{ 'struct': 'VirtioPMEMDeviceInfo',
> + 'data': { '*id': 'str',
Why is id optional? Does it make sense to have a device without an id?
> + 'memaddr': 'size',
> + 'size': 'size',
> + 'memdev': 'str'
> + }
> +}
> +
> ##
> # @MemoryDeviceInfo:
> #
> # Union containing information about a memory device
> #
> +# nvdimm is included since 2.12. virtio-pmem is included since 4.0.
4.1
> +#
> # Since: 2.1
> ##
> { 'union': 'MemoryDeviceInfo',
> 'data': { 'dimm': 'PCDIMMDeviceInfo',
> - 'nvdimm': 'PCDIMMDeviceInfo'
> + 'nvdimm': 'PCDIMMDeviceInfo',
> + 'virtio-pmem': 'VirtioPMEMDeviceInfo'
> }
> }
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/7] Qemu virtio pmem device, Pankaj Gupta, 2019/05/23
- [Qemu-devel] [PATCH 2/7] virtio-pci: Allow to specify additional interfaces for the base type, Pankaj Gupta, 2019/05/23
- [Qemu-devel] [PATCH 1/7] virtio-pmem: add virtio device, Pankaj Gupta, 2019/05/23
- Re: [Qemu-devel] [PATCH 1/7] virtio-pmem: add virtio device,
Eric Blake <=
- [Qemu-devel] [PATCH 3/7] virtio-pmem: sync linux headers, Pankaj Gupta, 2019/05/23
- [Qemu-devel] [PATCH 4/7] virtio-pci: Proxy for virtio-pmem, Pankaj Gupta, 2019/05/23
- [Qemu-devel] [PATCH 5/7] hmp: Handle virtio-pmem when printing memory device infos, Pankaj Gupta, 2019/05/23
- [Qemu-devel] [PATCH 6/7] numa: Handle virtio-pmem in NUMA stats, Pankaj Gupta, 2019/05/23
- [Qemu-devel] [PATCH 7/7] pc: Support for virtio-pmem-pci, Pankaj Gupta, 2019/05/23