[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 4/8] block/commit: Drop bdrv_child_try_set_perm()
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v3 4/8] block/commit: Drop bdrv_child_try_set_perm() |
Date: |
Wed, 22 May 2019 19:03:48 +0200 |
commit_top_bs never requests or unshares any permissions. There is no
reason to make this so explicit here.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
---
block/commit.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/block/commit.c b/block/commit.c
index 14e5bb394c..44b3083b84 100644
--- a/block/commit.c
+++ b/block/commit.c
@@ -110,8 +110,6 @@ static void commit_abort(Job *job)
* XXX Can (or should) we somehow keep 'consistent read' blocked even
* after the failed/cancelled commit job is gone? If we already wrote
* something to base, the intermediate images aren't valid any more. */
- bdrv_child_try_set_perm(s->commit_top_bs->backing, 0, BLK_PERM_ALL,
- &error_abort);
bdrv_replace_node(s->commit_top_bs, backing_bs(s->commit_top_bs),
&error_abort);
--
2.21.0
- [Qemu-devel] [PATCH v3 0/8] block: Ignore loosening perm restrictions failures, Max Reitz, 2019/05/22
- [Qemu-devel] [PATCH v3 4/8] block/commit: Drop bdrv_child_try_set_perm(),
Max Reitz <=
- [Qemu-devel] [PATCH v3 7/8] block: Ignore loosening perm restrictions failures, Max Reitz, 2019/05/22
- [Qemu-devel] [PATCH v3 2/8] block: Add bdrv_child_refresh_perms(), Max Reitz, 2019/05/22
- [Qemu-devel] [PATCH v3 3/8] block/mirror: Fix child permissions, Max Reitz, 2019/05/22
- [Qemu-devel] [PATCH v3 6/8] block: Add *tighten_restrictions to *check*_perm(), Max Reitz, 2019/05/22
- [Qemu-devel] [PATCH v3 5/8] block: Fix order in bdrv_replace_child(), Max Reitz, 2019/05/22
- [Qemu-devel] [PATCH v3 8/8] iotests: Test failure to loosen restrictions, Max Reitz, 2019/05/22
- [Qemu-devel] [PATCH v3 1/8] file-posix: Update open_flags in raw_set_perm(), Max Reitz, 2019/05/22
- Re: [Qemu-devel] [PATCH v3 0/8] block: Ignore loosening perm restrictions failures, Eric Blake, 2019/05/22