Re: [Qemu-devel] [PATCH v3 1/2] roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description

[Laurent Vivier]

On 06/05/2019 16:19, Philippe Mathieu-Daudé wrote:
> In commit 1cab464136b4 we incorrectly described the
> EDK2_BASETOOLS_OPTFLAGS can pass CPPFLAGS and CFLAGS
> options to the EDK2 build tools, but it only expands
> the CFLAGS (not to the CPPFLAGS).
> Update the description to be more accurate.
>
> Reported-by: Laszlo Ersek <address@hidden>
> Reviewed-by: Laszlo Ersek <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> v3: Squeezed 2 spaces (Laszlo)
> ---
>   roms/Makefile | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/roms/Makefile b/roms/Makefile
> index 0ce84a45ad5..ea6aec56abd 100644
> --- a/roms/Makefile
> +++ b/roms/Makefile
> @@ -121,8 +121,8 @@ build-efi-roms: build-pxe-roms
>                 $(patsubst %,bin-i386-efi/%.efidrv,$(pxerom_targets)) \
>                 $(patsubst %,bin-x86_64-efi/%.efidrv,$(pxerom_targets))
>   
> -# Build scripts can pass compiler/linker flags to the EDK2 build tools
> -# via the EDK2_BASETOOLS_OPTFLAGS (CPPFLAGS and CFLAGS) and
> +# Build scripts can pass compiler/linker flags to the EDK2
> +# build tools via the EDK2_BASETOOLS_OPTFLAGS (CFLAGS) and
>   # EDK2_BASETOOLS_LDFLAGS (LDFLAGS) environment variables.
>   #
>   # Example:

Applied to my trivial-patches branch.

Thanks,
Laurent