[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/3] edu: uses uint64_t in dma operation
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v4 3/3] edu: uses uint64_t in dma operation |
Date: |
Wed, 22 May 2019 13:01:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/10/19 6:43 PM, Li Qiang wrote:
> The dma related variable dma.dst/src/cnt is dma_addr_t, it is
> uint64_t in x64 platform. Change these usage from uint32_to
> uint64_t to avoid trancation in edu_dma_timer.
>
> Signed-off-by: Li Qiang <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> Change since v3:
> Change 'size2' para of 'edu_check_range' to 64-bits.
>
> hw/misc/edu.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/hw/misc/edu.c b/hw/misc/edu.c
> index 33de05141f..19e5545e2c 100644
> --- a/hw/misc/edu.c
> +++ b/hw/misc/edu.c
> @@ -98,23 +98,24 @@ static void edu_lower_irq(EduState *edu, uint32_t val)
> }
> }
>
> -static bool within(uint32_t addr, uint32_t start, uint32_t end)
> +static bool within(uint64_t addr, uint64_t start, uint64_t end)
> {
> return start <= addr && addr < end;
> }
>
> -static void edu_check_range(uint32_t addr, uint32_t size1, uint32_t start,
> - uint32_t size2)
> +static void edu_check_range(uint64_t addr, uint64_t size1, uint64_t start,
> + uint64_t size2)
> {
> - uint32_t end1 = addr + size1;
> - uint32_t end2 = start + size2;
> + uint64_t end1 = addr + size1;
> + uint64_t end2 = start + size2;
>
> if (within(addr, start, end2) &&
> end1 > addr && within(end1, start, end2)) {
> return;
> }
>
> - hw_error("EDU: DMA range 0x%.8x-0x%.8x out of bounds (0x%.8x-0x%.8x)!",
> + hw_error("EDU: DMA range 0x%016"PRIx64"-0x%016"PRIx64
> + " out of bounds (0x%016"PRIx64"-0x%016"PRIx64")!",
> addr, end1 - 1, start, end2 - 1);
> }
>
> @@ -139,13 +140,13 @@ static void edu_dma_timer(void *opaque)
> }
>
> if (EDU_DMA_DIR(edu->dma.cmd) == EDU_DMA_FROM_PCI) {
> - uint32_t dst = edu->dma.dst;
> + uint64_t dst = edu->dma.dst;
> edu_check_range(dst, edu->dma.cnt, DMA_START, DMA_SIZE);
> dst -= DMA_START;
> pci_dma_read(&edu->pdev, edu_clamp_addr(edu, edu->dma.src),
> edu->dma_buf + dst, edu->dma.cnt);
> } else {
> - uint32_t src = edu->dma.src;
> + uint64_t src = edu->dma.src;
> edu_check_range(src, edu->dma.cnt, DMA_START, DMA_SIZE);
> src -= DMA_START;
> pci_dma_write(&edu->pdev, edu_clamp_addr(edu, edu->dma.dst),
>
- [Qemu-devel] [PATCH v4 0/3] hw: edu: some fixes, Li Qiang, 2019/05/10
- [Qemu-devel] [PATCH v4 1/3] edu: mmio: allow 64-bit access, Li Qiang, 2019/05/10
- [Qemu-devel] [PATCH v4 3/3] edu: uses uint64_t in dma operation, Li Qiang, 2019/05/10
- Re: [Qemu-devel] [PATCH v4 3/3] edu: uses uint64_t in dma operation,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v4 2/3] edu: mmio: allow 64-bit access in read dispatch, Li Qiang, 2019/05/10
- Re: [Qemu-devel] [PATCH v4 0/3] hw: edu: some fixes, Peter Xu, 2019/05/10
- Re: [Qemu-devel] [PATCH v4 0/3] hw: edu: some fixes, Li Qiang, 2019/05/21