Re: [Qemu-devel] [PATCH 1/2] sphinx: add qmp_lexer

[Eduardo Habkost]

On Tue, May 21, 2019 at 04:06:56PM -0400, John Snow wrote:
> Sphinx, through Pygments, does not like annotated json examples very
> much. In some versions of Sphinx (1.7), it will render the non-json
> portions of code blocks in red, but in newer versions (2.0) it will
> throw an exception and not highlight the block at all. Though we can
> suppress this warning, it doesn't bring back highlighting on non-strict
> json blocks.
> 
> We can alleviate this by creating a custom lexer for QMP examples that
> allows us to properly highlight these examples in a robust way, keeping
> our directionality notations.
> 
> Signed-off-by: Eduardo Habkost <address@hidden>
> Signed-off-by: John Snow <address@hidden>

Thanks for figuring out how to integrate it into Sphinx!

Reviewed-by: Eduardo Habkost <address@hidden>

-- 
Eduardo