Re: [Qemu-devel] [PATCH v2] authz: optimize linking of objects for authorization services

[Richard Henderson]

On 5/21/19 5:56 AM, Daniel P. Berrangé wrote:
> The core authorization API is a dependancy of the crypto code for the
> TLS servers. The TLS server code is pulled into anything which links
> to the crypto objects, which is every QEMU tool. This in turns means
> that every tool ended up linking to the authz code, which in turn
> pulls in the PAM library dep.
> 
> This splits the authz code so that everything links to the base object
> which defines the API. Only the system emulators and qemu-nbd link to
> the object classes providing the implementations of the authz object
> API. This has the effect of removing the PAM library dep from qemu-img,
> qemu-io and other helper tools.
> 
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> ---
> 
> In v2:
> 
>   - Now with 100% less unit test failures due to missing objs :-)
> 
>  Makefile               | 5 +++--
>  Makefile.objs          | 1 +
>  Makefile.target        | 3 ++-
>  authz/Makefile.objs    | 9 +++++----
>  tests/Makefile.include | 6 +++---
>  5 files changed, 14 insertions(+), 10 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~