[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] authz: optimize linking of objects for authoriz
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH] authz: optimize linking of objects for authorization services |
Date: |
Tue, 21 May 2019 10:39:12 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/21/19 5:32 AM, Daniel P. Berrangé wrote:
> The core authorization API is a dependancy of the crypto code for the
> TLS servers. The TLS server code is pulled into anything which links
> to the crypto objects, which is every QEMU tool. This in turns means
> that every tool ended up linking to the authz code, which in turn
> pulls in the PAM library dep.
>
> This splits the authz code so that everything links to the base object
> which defines the API. Only the system emulators and qemu-nbd link to
> the object classes providing the implementations of the authz object
> API. This has the effect of removing the PAM library dep from qemu-img,
> qemu-io and other helper tools.
>
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> ---
> Makefile | 5 +++--
> Makefile.objs | 1 +
> Makefile.target | 3 ++-
> authz/Makefile.objs | 9 +++++----
> 4 files changed, 11 insertions(+), 7 deletions(-)
No changes to tests/? Surely that means some tests no longer link?
r~