[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 2/7] virtio-pmem: Add virtio pmem driver
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v10 2/7] virtio-pmem: Add virtio pmem driver |
Date: |
Tue, 21 May 2019 09:51:35 -0400 |
On Tue, May 21, 2019 at 07:07:08PM +0530, Pankaj Gupta wrote:
> diff --git a/include/uapi/linux/virtio_pmem.h
> b/include/uapi/linux/virtio_pmem.h
> new file mode 100644
> index 000000000000..7a3e2fe52415
> --- /dev/null
> +++ b/include/uapi/linux/virtio_pmem.h
> @@ -0,0 +1,35 @@
> +/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */
> +/*
> + * Definitions for virtio-pmem devices.
> + *
> + * Copyright (C) 2019 Red Hat, Inc.
> + *
> + * Author(s): Pankaj Gupta <address@hidden>
> + */
> +
> +#ifndef _UAPI_LINUX_VIRTIO_PMEM_H
> +#define _UAPI_LINUX_VIRTIO_PMEM_H
> +
> +#include <linux/types.h>
> +#include <linux/virtio_types.h>
> +#include <linux/virtio_ids.h>
> +#include <linux/virtio_config.h>
> +
> +struct virtio_pmem_config {
> + __le64 start;
> + __le64 size;
> +};
> +
config generally should be __u64.
Are you sure sparse does not complain?
> +#define VIRTIO_PMEM_REQ_TYPE_FLUSH 0
> +
> +struct virtio_pmem_resp {
> + /* Host return status corresponding to flush request */
> + __virtio32 ret;
> +};
> +
> +struct virtio_pmem_req {
> + /* command type */
> + __virtio32 type;
> +};
> +
> +#endif
> --
> 2.20.1
Sorry why are these __virtio32 not __le32?
--
MST
- [Qemu-devel] [PATCH v10 0/7] virtio pmem driver, Pankaj Gupta, 2019/05/21
- [Qemu-devel] [PATCH v10 6/7] ext4: disable map_sync for async flush, Pankaj Gupta, 2019/05/21
- [Qemu-devel] [PATCH v10 4/7] dm: enable synchronous dax, Pankaj Gupta, 2019/05/21
- [Qemu-devel] [PATCH v10 7/7] xfs: disable map_sync for async flush, Pankaj Gupta, 2019/05/21
- [Qemu-devel] [PATCH v10 5/7] dax: check synchronous mapping is supported, Pankaj Gupta, 2019/05/21
- [Qemu-devel] [PATCH v10 3/7] libnvdimm: add dax_dev sync flag, Pankaj Gupta, 2019/05/21
- [Qemu-devel] [PATCH v10 1/7] libnvdimm: nd_region flush callback support, Pankaj Gupta, 2019/05/21
- [Qemu-devel] [PATCH v10 2/7] virtio-pmem: Add virtio pmem driver, Pankaj Gupta, 2019/05/21
- Re: [Qemu-devel] [PATCH v10 2/7] virtio-pmem: Add virtio pmem driver,
Michael S. Tsirkin <=