Re: [Qemu-devel] [RFC 00/10] Add kernel-doc support to our Sphinx setup

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [RFC 00/10] Add kernel-doc support to our Sphinx setup
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
02a0d0d337 Makefile: disable Sphinx nitpicking
2124e52316 memory.h: attempted kernel-doc fixes
f73463aa82 docs: Add kernel-doc API documentation to memory.rst
e775bbb9db memory.h: Fix kerneldoc syntax issues
b7a8bdc1ba docs: Create bitops.rst as example of kernel-docs
19ff73c38a bitops.h: Silence kernel-doc complaints
5a4c54aa09 docs/conf.py: Ignore some missing references in nitpick mode
a08b2a1c93 docs/conf.py: Enable use of kerneldoc sphinx extension
c4f9da74ce docs: Add kerneldoc sphinx module from Linux
e97b2d12d4 scripts/kernel-doc: Import kernel-doc script from Linux

=== OUTPUT BEGIN ===
1/10 Checking commit e97b2d12d441 (scripts/kernel-doc: Import kernel-doc script 
from Linux)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100755

total: 0 errors, 1 warnings, 2223 lines checked

Patch 1/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/10 Checking commit c4f9da74cecb (docs: Add kerneldoc sphinx module from Linux)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

WARNING: line over 80 characters
#84: FILE: docs/sphinx/kerneldoc.py:66:
+        tab_width = self.options.get('tab-width', 
self.state.document.settings.tab_width)

WARNING: line over 80 characters
#113: FILE: docs/sphinx/kerneldoc.py:95:
+            p = subprocess.Popen(cmd, stdout=subprocess.PIPE, 
stderr=subprocess.PIPE)

ERROR: line over 90 characters
#121: FILE: docs/sphinx/kerneldoc.py:103:
+                env.app.warn('kernel-doc \'%s\' failed with return code %d' % 
(" ".join(cmd), p.returncode))

WARNING: line over 80 characters
#122: FILE: docs/sphinx/kerneldoc.py:104:
+                return [nodes.error(None, nodes.paragraph(text = "kernel-doc 
missing"))]

WARNING: line over 80 characters
#126: FILE: docs/sphinx/kerneldoc.py:108:
+            lines = statemachine.string2lines(out, tab_width, 
convert_whitespace=True)

ERROR: line over 90 characters
#142: FILE: docs/sphinx/kerneldoc.py:124:
+            buf = self.state.memo.title_styles, self.state.memo.section_level, 
self.state.memo.reporter

WARNING: line over 80 characters
#143: FILE: docs/sphinx/kerneldoc.py:125:
+            self.state.memo.reporter = AutodocReporter(result, 
self.state.memo.reporter)

ERROR: line over 90 characters
#148: FILE: docs/sphinx/kerneldoc.py:130:
+                self.state.memo.title_styles, self.state.memo.section_level, 
self.state.memo.reporter = buf

WARNING: line over 80 characters
#155: FILE: docs/sphinx/kerneldoc.py:137:
+            return [nodes.error(None, nodes.paragraph(text = "kernel-doc 
missing"))]

total: 3 errors, 7 warnings, 150 lines checked

Patch 2/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/10 Checking commit a08b2a1c931a (docs/conf.py: Enable use of kerneldoc sphinx 
extension)
4/10 Checking commit 5a4c54aa09f6 (docs/conf.py: Ignore some missing references 
in nitpick mode)
5/10 Checking commit 19ff73c38a62 (bitops.h: Silence kernel-doc complaints)
6/10 Checking commit b7a8bdc1ba62 (docs: Create bitops.rst as example of 
kernel-docs)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100644

total: 0 errors, 1 warnings, 12 lines checked

Patch 6/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/10 Checking commit e775bbb9db99 (memory.h: Fix kerneldoc syntax issues)
8/10 Checking commit f73463aa82c3 (docs: Add kernel-doc API documentation to 
memory.rst)
9/10 Checking commit 2124e5231685 (memory.h: attempted kernel-doc fixes)
WARNING: line over 80 characters
#35: FILE: include/exec/memory.h:228:
+ * -  @attrs_to_index returns the IOMMU index for a set of transaction 
attributes

WARNING: line over 80 characters
#46: FILE: include/exec/memory.h:403:
+ * struct MemoryListener: callbacks structure for updates to the physical 
memory map

WARNING: line over 80 characters
#55: FILE: include/exec/memory.h:437:
+ * struct AddressSpace: describes a mapping of addresses to #MemoryRegion 
objects

ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 3 warnings, 64 lines checked

Patch 9/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/10 Checking commit 02a0d0d33747 (Makefile: disable Sphinx nitpicking)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden