[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v10 07/20] gdbstub: Implement breakpoint commands (Z
From: |
Jon Doron |
Subject: |
[Qemu-devel] [PATCH v10 07/20] gdbstub: Implement breakpoint commands (Z/z pkt) with new infra |
Date: |
Tue, 21 May 2019 12:59:35 +0300 |
Signed-off-by: Jon Doron <address@hidden>
---
gdbstub.c | 84 +++++++++++++++++++++++++++++++++++++++++++------------
1 file changed, 66 insertions(+), 18 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index 129a47230f..c59a6765cd 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -950,7 +950,7 @@ static inline int xlat_gdb_type(CPUState *cpu, int gdbtype)
}
#endif
-static int gdb_breakpoint_insert(target_ulong addr, target_ulong len, int type)
+static int gdb_breakpoint_insert(int type, target_ulong addr, target_ulong len)
{
CPUState *cpu;
int err = 0;
@@ -1591,6 +1591,52 @@ static void handle_set_thread(GdbCmdContext *gdb_ctx,
void *user_ctx)
}
}
+static void handle_insert_bp(GdbCmdContext *gdb_ctx, void *user_ctx)
+{
+ int res;
+
+ if (gdb_ctx->num_params != 3) {
+ put_packet(gdb_ctx->s, "E22");
+ return;
+ }
+
+ res = gdb_breakpoint_insert(gdb_ctx->params[0].val_ul,
+ gdb_ctx->params[1].val_ull,
+ gdb_ctx->params[2].val_ull);
+ if (res >= 0) {
+ put_packet(gdb_ctx->s, "OK");
+ return;
+ } else if (res == -ENOSYS) {
+ put_packet(gdb_ctx->s, "");
+ return;
+ }
+
+ put_packet(gdb_ctx->s, "E22");
+}
+
+static void handle_remove_bp(GdbCmdContext *gdb_ctx, void *user_ctx)
+{
+ int res;
+
+ if (gdb_ctx->num_params != 3) {
+ put_packet(gdb_ctx->s, "E22");
+ return;
+ }
+
+ res = gdb_breakpoint_remove(gdb_ctx->params[0].val_ul,
+ gdb_ctx->params[1].val_ull,
+ gdb_ctx->params[2].val_ull);
+ if (res >= 0) {
+ put_packet(gdb_ctx->s, "OK");
+ return;
+ } else if (res == -ENOSYS) {
+ put_packet(gdb_ctx->s, "");
+ return;
+ }
+
+ put_packet(gdb_ctx->s, "E22");
+}
+
static int gdb_handle_packet(GDBState *s, const char *line_buf)
{
CPUState *cpu;
@@ -1846,24 +1892,26 @@ static int gdb_handle_packet(GDBState *s, const char
*line_buf)
put_packet(s, "OK");
break;
case 'Z':
+ {
+ static const GdbCmdParseEntry insert_bp_cmd_desc = {
+ .handler = handle_insert_bp,
+ .cmd = "Z",
+ .cmd_startswith = 1,
+ .schema = "l?L?L0"
+ };
+ cmd_parser = &insert_bp_cmd_desc;
+ }
+ break;
case 'z':
- type = strtoul(p, (char **)&p, 16);
- if (*p == ',')
- p++;
- addr = strtoull(p, (char **)&p, 16);
- if (*p == ',')
- p++;
- len = strtoull(p, (char **)&p, 16);
- if (ch == 'Z')
- res = gdb_breakpoint_insert(addr, len, type);
- else
- res = gdb_breakpoint_remove(addr, len, type);
- if (res >= 0)
- put_packet(s, "OK");
- else if (res == -ENOSYS)
- put_packet(s, "");
- else
- put_packet(s, "E22");
+ {
+ static const GdbCmdParseEntry remove_bp_cmd_desc = {
+ .handler = handle_remove_bp,
+ .cmd = "z",
+ .cmd_startswith = 1,
+ .schema = "l?L?L0"
+ };
+ cmd_parser = &remove_bp_cmd_desc;
+ }
break;
case 'H':
{
--
2.21.0
- [Qemu-devel] [PATCH v10 00/20] gdbstub: Refactor command packets handler, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 01/20] gdbstub: Add infrastructure to parse cmd packets, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 03/20] gdbstub: Implement thread_alive (T pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 02/20] gdbstub: Implement deatch (D pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 04/20] gdbstub: Implement continue (c pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 06/20] gdbstub: Implement set_thread (H pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 05/20] gdbstub: Implement continue with signal (C pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 07/20] gdbstub: Implement breakpoint commands (Z/z pkt) with new infra,
Jon Doron <=
- [Qemu-devel] [PATCH v10 08/20] gdbstub: Implement set register (P pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 09/20] gdbstub: Implement get register (p pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 10/20] gdbstub: Implement write memory (M pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 12/20] gdbstub: Implement write all registers (G pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 13/20] gdbstub: Implement read all registers (g pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 11/20] gdbstub: Implement read memory (m pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 14/20] gdbstub: Implement file io (F pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 19/20] gdbstub: Clear unused variables in gdb_handle_packet, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 15/20] gdbstub: Implement step (s pkt) with new infra, Jon Doron, 2019/05/21
- [Qemu-devel] [PATCH v10 16/20] gdbstub: Implement v commands with new infra, Jon Doron, 2019/05/21