[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/15] migration: No need to take rcu during
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/15] migration: No need to take rcu during sync_dirty_bitmap |
Date: |
Tue, 21 May 2019 10:28:56 +0800 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, May 20, 2019 at 12:48:01PM +0200, Paolo Bonzini wrote:
> On 20/05/19 05:08, Peter Xu wrote:
> > cpu_physical_memory_sync_dirty_bitmap() has one RAMBlock* as
> > parameter, which means that it must be with RCU read lock held
> > already. Taking it again inside seems redundant. Removing it.
> > Instead comment on the functions about the RCU read lock.
> >
> > Reviewed-by: Paolo Bonzini <address@hidden>
> > Signed-off-by: Peter Xu <address@hidden>
> > ---
> > include/exec/ram_addr.h | 5 +----
> > migration/ram.c | 1 +
> > 2 files changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h
> > index 139ad79390..993fb760f3 100644
> > --- a/include/exec/ram_addr.h
> > +++ b/include/exec/ram_addr.h
> > @@ -408,6 +408,7 @@ static inline void
> > cpu_physical_memory_clear_dirty_range(ram_addr_t start,
> > }
> >
> >
> > +/* Must be with rcu read lock held */
>
> The usual way to spell this is "Called within RCU critical section.",
> otherwise the patch looks good.
Sure, I'm switching to this with the r-b kept.
Thanks,
--
Peter Xu
- [Qemu-devel] [PATCH v2 00/15] kvm/migration: support KVM_CLEAR_DIRTY_LOG, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 01/15] checkpatch: Allow SPDX-License-Identifier, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 03/15] migration: No need to take rcu during sync_dirty_bitmap, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 04/15] memory: Remove memory_region_get_dirty(), Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 05/15] memory: Don't set migration bitmap when without migration, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 02/15] linux-headers: Update to Linux 5.2-rc1, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 06/15] bitmap: Add bitmap_copy_with_{src|dst}_offset(), Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 07/15] memory: Pass mr into snapshot_and_clear_dirty, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 09/15] kvm: Update comments for sync_dirty_bitmap, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 08/15] memory: Introduce memory listener hook log_clear(), Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 10/15] kvm: Persistent per kvmslot dirty bitmap, Peter Xu, 2019/05/19
- [Qemu-devel] [PATCH v2 11/15] kvm: Introduce slots lock for memory listener, Peter Xu, 2019/05/19