[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 0/5] fw_cfg_test refactor and add two test ca

From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH v2 0/5] fw_cfg_test refactor and add two test cases
Date: Mon, 20 May 2019 23:29:38 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

Hi Li,

On 5/17/19 4:28 AM, Li Qiang wrote:
> Ping.....
> Li Qiang <address@hidden <mailto:address@hidden>> 于2019年5月9日周四
> 下午5:57写道:
>     Ping.... this serials.

I apologize I hold this series for too long.
With your v1 I wanted to clarify the commit descriptions without asking
you to send a v2, then I reword your patches and the same day you sent
your v2, then I had mixed feeling about how to do to not frustrate you
asking to respin again, but I ended it worst :(
I adapted the descriptions on your v2 and will repost as v3, then merge
if you are OK with v3.



>     Thanks,
>     Li Qiang
>     Li Qiang <address@hidden <mailto:address@hidden>> 于2019年4月24日周
>     三 下午10:07写道:
>         In the disscuss of adding reboot timeout test case:
>         https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg03304.html
>         Philippe suggested we should uses the only related option for one
>         specific test. However currently we uses one QTestState for all the
>         test cases. In order to achieve Philippe's idea, I split the
>         test case
>         for its own QTestState. As this patchset has changed a lot, I
>         don't bump
>         the version.
>         Change since v1:
>         Add a patch to store the reboot_timeout as little endian
>         Fix the endian issue per Thomas's review
>         Li Qiang (5):
>           tests: refactor fw_cfg_test
>           tests: fw_cfg: add a function to get the fw_cfg file
>           fw_cfg: reboot: store reboot-timeout as little endian
>           tests: fw_cfg: add reboot_timeout test case
>           tests: fw_cfg: add splash time test case
>          hw/nvram/fw_cfg.c     |   4 +-
>          tests/fw_cfg-test.c   | 125
>         +++++++++++++++++++++++++++++++++++++++---
>          tests/libqos/fw_cfg.c |  55 +++++++++++++++++++
>          tests/libqos/fw_cfg.h |   9 +++
>          4 files changed, 184 insertions(+), 9 deletions(-)
>         -- 
>         2.17.1

reply via email to

[Prev in Thread] Current Thread [Next in Thread]